Save To Pocket popup UI is too bright with dark browser-themes
Categories
(Firefox :: Pocket, defect)
Tracking
()
People
(Reporter: dholbert, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
screenshot of how this dialog looked before the Save-to-Pocket refresh
STR:
- Activate a dark theme (by e.g. visiting
about:addons, clicking "Themes", and then clicking the "Enable" Button for Dark) - Click the Save-to-Pocket button on the Firefox toolbar.
ACTUAL RESULTS:
Bright white popup.
EXPECTED RESULTS:
Popup with dark background, like e.g. the background that we use for other toolbar panels popups (like the hamburger menu, the page-info button, the bookmarks/history & downloads toolbar-buttons).
It looks like this got a bit more noticeable last week as part of the "Save to pocket refresh" (bug 1746013). Before the refresh's new UI was activated, the popup was still "light-themed" but it wasn't quite as bright-white as it is now.
|
Reporter | |
Comment 1•3 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #0)
It looks like this got a bit more noticeable last week as part of the "Save to pocket refresh" (bug 1746013). Before the refresh's new UI was activated, the popup was still "light-themed" but it wasn't quite as bright-white as it is now.
I'll attach screenshots to illustrate this a bit -- first, here's what this looks like before the refresh. (This was taken in Nightly 2022-04-01, and I think it matches how this UI looks in current Firefox releases.)
|
|
Reporter | |
Comment 2•3 years ago
•
|
||
Here's the screenshot in current Nightly.
Comparing to the previous screenshot:
- the whole dialog now has a light background, vs. before, the top half was light and the bottom half was more neutral.
- the light background is fully-white, i.e.
#ffffff, vs. the slightly-more-muted#fbfbfbthat we had before the refresh. (Ideally we should take these colors from the theme/colorway if we can?)
|
||
Comment 3•3 years ago
|
||
Good catch, and thanks for the feedback. Bug 1759895 is adding a fully implemented dark mode to the Pocket panels (finally), which I think finishing that is probably the best path forward to resolving this issue. The issue you see from the lighter new panels related to the refresh is nightly only for the time being while we flesh out concerns like the one you raised.
It's worth noting that bug 1759895 is only scoped to support dark mode, not any colorway theme. Any theme other than dark mode would end up with light still.
|
|
Reporter | |
Comment 4•3 years ago
|
||
Thanks! I'll dupe this to bug 1759895. Glad there are already plans to add a dark-mode-friendly UI option.
(For the light-mode UI, I was thinking that #ffffff was whiter than what we usually use for panel backgrounds; but now that I take a look in a light-mode profile, it does indeed look like the hamburger menu and site-info doorhanger use #ffffff fully-white backgrounds! So, that does seem to make sense after all. I suppose I've gotten too used to my dark-mode existence and to the previous not-quite-white pocket menu-dropdown.)
Description
•