1764224 - Assertion failure: child->IsPrimaryFrame() (We only look at the primary frame in ReflowFinished), at src/layout/generic/nsVideoFrame.cpp:322

Tyson Smith [:tsmith]

Reporter

Description

•

2 years ago

Attached file testcase.html — Details

Found while fuzzing m-c 20220408-0671f5ff7249 (--enable-debug --enable-fuzzing)

To reproduce via Grizzly Replay:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch -d --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html

Assertion failure: child->IsPrimaryFrame() (We only look at the primary frame in ReflowFinished), at src/layout/generic/nsVideoFrame.cpp:322

#0 0x7fbfa97c68ea in nsVideoFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsVideoFrame.cpp:321:9
#1 0x7fbfa9641548 in nsAbsoluteContainingBlock::ReflowAbsoluteFrame(nsIFrame*, nsPresContext*, mozilla::ReflowInput const&, nsRect const&, nsAbsoluteContainingBlock::AbsPosReflowFlags, nsIFrame*, nsReflowStatus&, mozilla::OverflowAreas*) src/layout/generic/nsAbsoluteContainingBlock.cpp:813:14
#2 0x7fbfa963f630 in nsAbsoluteContainingBlock::Reflow(nsContainerFrame*, nsPresContext*, mozilla::ReflowInput const&, nsReflowStatus&, nsRect const&, nsAbsoluteContainingBlock::AbsPosReflowFlags, mozilla::OverflowAreas*) src/layout/generic/nsAbsoluteContainingBlock.cpp:221:7
#3 0x7fbfa971beed in nsIFrame::ReflowAbsoluteFrames(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&, bool) src/layout/generic/nsIFrame.cpp:6925:24
#4 0x7fbfa977ee6d in nsPageContentFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsPageContentFrame.cpp:140:3
#5 0x7fbfa963eec6 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1045:14
#6 0x7fbfa9780f87 in nsPageFrame::ReflowPageContent(nsPresContext*, mozilla::ReflowInput const&) src/layout/generic/nsPageFrame.cpp:146:3
#7 0x7fbfa97815c8 in nsPageFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsPageFrame.cpp:169:13
#8 0x7fbfa966f10e in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1005:14
#9 0x7fbfa961c28d in mozilla::PrintedSheetFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/PrintedSheetFrame.cpp:132:5
#10 0x7fbfa963eec6 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1045:14
#11 0x7fbfa978537d in nsPageSequenceFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsPageSequenceFrame.cpp:370:5
#12 0x7fbfa966f10e in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1005:14
#13 0x7fbfa966e36b in nsCanvasFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsCanvasFrame.cpp:791:7
#14 0x7fbfa963eec6 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1045:14
#15 0x7fbfa963e68d in mozilla::ViewportFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/ViewportFrame.cpp:374:7
#16 0x7fbfa953c0c2 in mozilla::PresShell::DoReflow(nsIFrame*, bool, mozilla::OverflowChangedTracker*) src/layout/base/PresShell.cpp:9602:11
#17 0x7fbfa95465ae in mozilla::PresShell::ProcessReflowCommands(bool) src/layout/base/PresShell.cpp:9773:24
#18 0x7fbfa9545855 in mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) src/layout/base/PresShell.cpp:4351:11
#19 0x7fbfa99cb06b in nsPrintJob::ReflowPrintObject(mozilla::UniquePtr<nsPrintObject, mozilla::DefaultDelete<nsPrintObject> > const&) src/layout/printing/nsPrintJob.cpp:1607:14
#20 0x7fbfa99ca55f in nsPrintJob::ReflowDocList(mozilla::UniquePtr<nsPrintObject, mozilla::DefaultDelete<nsPrintObject> > const&, bool) src/layout/printing/nsPrintJob.cpp:1169:3
#21 0x7fbfa99c705c in nsPrintJob::InitPrintDocConstruction(bool) src/layout/printing/nsPrintJob.cpp:1209:5
#22 0x7fbfa99c50d5 in nsPrintJob::DoCommonPrint(bool, nsIPrintSettings*, nsIWebProgressListener*, mozilla::dom::Document*) src/layout/printing/nsPrintJob.cpp:613:3
#23 0x7fbfa99c72ed in CommonPrint src/layout/printing/nsPrintJob.cpp:457:17
#24 0x7fbfa99c72ed in nsPrintJob::Print(mozilla::dom::Document*, nsIPrintSettings*, nsIWebProgressListener*) src/layout/printing/nsPrintJob.cpp:629:10
#25 0x7fbfa95c205d in nsDocumentViewer::Print(nsIPrintSettings*, nsIWebProgressListener*) src/layout/base/nsDocumentViewer.cpp:2935:18
#26 0x7fbfa5d72140 in nsGlobalWindowOuter::Print(nsIPrintSettings*, nsIWebProgressListener*, nsIDocShell*, nsGlobalWindowOuter::IsPreview, nsGlobalWindowOuter::IsForWindowDotPrint, std::function<void (mozilla::dom::PrintPreviewResultInfo const&)>&&, mozilla::ErrorResult&) src/dom/base/nsGlobalWindowOuter.cpp:5315:24
#27 0x7fbfa8a8228e in mozilla::dom::BrowserChild::RecvPrint(mozilla::dom::MaybeDiscarded<mozilla::dom::BrowsingContext> const&, mozilla::embedding::PrintData const&) src/dom/ipc/BrowserChild.cpp:2549:18
#28 0x7fbfa8b88897 in mozilla::dom::PBrowserChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PBrowserChild.cpp:7495:56
#29 0x7fbfa8be8d8b in mozilla::dom::PContentChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PContentChild.cpp:8896:32
#30 0x7fbfa511fff1 in mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) src/ipc/glue/MessageChannel.cpp:1707:25
#31 0x7fbfa511d227 in mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message&&) src/ipc/glue/MessageChannel.cpp:1632:9
#32 0x7fbfa511dd1d in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::ipc::MessageChannel::MessageTask&) src/ipc/glue/MessageChannel.cpp:1493:3
#33 0x7fbfa511e8ae in mozilla::ipc::MessageChannel::MessageTask::Run() src/ipc/glue/MessageChannel.cpp:1528:14
#34 0x7fbfa4589b6e in mozilla::RunnableTask::Run() src/xpcom/threads/TaskController.cpp:467:16
#35 0x7fbfa45640b6 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) src/xpcom/threads/TaskController.cpp:780:26
#36 0x7fbfa4562d53 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) src/xpcom/threads/TaskController.cpp:612:15
#37 0x7fbfa4562fc3 in mozilla::TaskController::ProcessPendingMTTask(bool) src/xpcom/threads/TaskController.cpp:390:36
#38 0x7fbfa458ec09 in operator() src/xpcom/threads/TaskController.cpp:127:37
#39 0x7fbfa458ec09 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_1>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:531:5
#40 0x7fbfa4578863 in nsThread::ProcessNextEvent(bool, bool*) src/xpcom/threads/nsThread.cpp:1187:16
#41 0x7fbfa457f28d in NS_ProcessNextEvent(nsIThread*, bool) src/xpcom/threads/nsThreadUtils.cpp:465:10
#42 0x7fbfa5d7469c in bool mozilla::SpinEventLoopUntil<(mozilla::ProcessFailureBehavior)1, nsGlobalWindowOuter::Print(nsIPrintSettings*, nsIWebProgressListener*, nsIDocShell*, nsGlobalWindowOuter::IsPreview, nsGlobalWindowOuter::IsForWindowDotPrint, std::function<void (mozilla::dom::PrintPreviewResultInfo const&)>&&, mozilla::ErrorResult&)::$_3>(nsTSubstring<char> const&, nsGlobalWindowOuter::Print(nsIPrintSettings*, nsIWebProgressListener*, nsIDocShell*, nsGlobalWindowOuter::IsPreview, nsGlobalWindowOuter::IsForWindowDotPrint, std::function<void (mozilla::dom::PrintPreviewResultInfo const&)>&&, mozilla::ErrorResult&)::$_3&&, nsIThread*) /builds/worker/workspace/obj-build/dist/include/mozilla/SpinEventLoopUntil.h:176:25
#43 0x7fbfa5d72196 in nsGlobalWindowOuter::Print(nsIPrintSettings*, nsIWebProgressListener*, nsIDocShell*, nsGlobalWindowOuter::IsPreview, nsGlobalWindowOuter::IsForWindowDotPrint, std::function<void (mozilla::dom::PrintPreviewResultInfo const&)>&&, mozilla::ErrorResult&) src/dom/base/nsGlobalWindowOuter.cpp:5337:5
#44 0x7fbfa5d709e2 in nsGlobalWindowOuter::PrintOuter(mozilla::ErrorResult&) src/dom/base/nsGlobalWindowOuter.cpp:5136:3
#45 0x7fbfa6ef3e23 in mozilla::dom::Window_Binding::print(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/WindowBinding.cpp:3118:24
#46 0x7fbfa74d21e4 in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::MaybeCrossOriginObjectThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) src/dom/bindings/BindingUtils.cpp:3270:13
#47 0x7fbfac91132f in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) src/js/src/vm/Interpreter.cpp:420:13
#48 0x7fbfac910b9d in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) src/js/src/vm/Interpreter.cpp:507:12
#49 0x7fbfac911fde in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) src/js/src/vm/Interpreter.cpp:567:10
#50 0x7fbfac908156 in CallFromStack src/js/src/vm/Interpreter.cpp:571:10
#51 0x7fbfac908156 in Interpret(JSContext*, js::RunState&) src/js/src/vm/Interpreter.cpp:3293:16
#52 0x7fbfac8fefa3 in js::RunScript(JSContext*, js::RunState&) src/js/src/vm/Interpreter.cpp:389:13
#53 0x7fbfac910a98 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) src/js/src/vm/Interpreter.cpp:539:13
#54 0x7fbfac911fde in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) src/js/src/vm/Interpreter.cpp:567:10
#55 0x7fbfac9121e1 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) src/js/src/vm/Interpreter.cpp:584:8
#56 0x7fbfab5a1301 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) src/js/src/vm/CallAndConstruct.cpp:117:10
#57 0x7fbfa6d8b169 in mozilla::dom::IdleRequestCallback::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::dom::IdleDeadline&, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/WindowBinding.cpp:852:8
#58 0x7fbfa5e25aa9 in mozilla::dom::IdleRequestCallback::Call(mozilla::dom::IdleDeadline&, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WindowBinding.h:695:12
#59 0x7fbfa5f9c4a6 in Call /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WindowBinding.h:708:12
#60 0x7fbfa5f9c4a6 in mozilla::dom::IdleRequest::IdleRun(nsPIDOMWindowInner*, double, bool) src/dom/base/IdleRequest.cpp:61:13
#61 0x7fbfa5d0d336 in nsGlobalWindowInner::RunIdleRequest(mozilla::dom::IdleRequest*, double, bool) src/dom/base/nsGlobalWindowInner.cpp:739:12
#62 0x7fbfa5d0c0ed in nsGlobalWindowInner::ExecuteIdleRequest(mozilla::TimeStamp) src/dom/base/nsGlobalWindowInner.cpp:767:3
#63 0x7fbfa5d0bdf3 in IdleRequestExecutor::Run() src/dom/base/nsGlobalWindowInner.cpp:608:13
#64 0x7fbfa4589b6e in mozilla::RunnableTask::Run() src/xpcom/threads/TaskController.cpp:467:16
#65 0x7fbfa45640b6 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) src/xpcom/threads/TaskController.cpp:780:26
#66 0x7fbfa4562e79 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) src/xpcom/threads/TaskController.cpp:654:15
#67 0x7fbfa4562fc3 in mozilla::TaskController::ProcessPendingMTTask(bool) src/xpcom/threads/TaskController.cpp:390:36
#68 0x7fbfa458eb96 in operator() src/xpcom/threads/TaskController.cpp:124:37
#69 0x7fbfa458eb96 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:531:5
#70 0x7fbfa4578863 in nsThread::ProcessNextEvent(bool, bool*) src/xpcom/threads/nsThread.cpp:1187:16
#71 0x7fbfa457f28d in NS_ProcessNextEvent(nsIThread*, bool) src/xpcom/threads/nsThreadUtils.cpp:465:10
#72 0x7fbfa51259a6 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:85:21
#73 0x7fbfa5042627 in MessageLoop::RunInternal() src/ipc/chromium/src/base/message_loop.cc:380:10
#74 0x7fbfa5042532 in RunHandler src/ipc/chromium/src/base/message_loop.cc:373:3
#75 0x7fbfa5042532 in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:355:3
#76 0x7fbfa9208ba8 in nsBaseAppShell::Run() src/widget/nsBaseAppShell.cpp:137:27
#77 0x7fbfab31aee3 in XRE_RunAppShell() src/toolkit/xre/nsEmbedFunctions.cpp:870:20
#78 0x7fbfa512689a in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:235:9
#79 0x7fbfa5042627 in MessageLoop::RunInternal() src/ipc/chromium/src/base/message_loop.cc:380:10
#80 0x7fbfa5042532 in RunHandler src/ipc/chromium/src/base/message_loop.cc:373:3
#81 0x7fbfa5042532 in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:355:3
#82 0x7fbfab31a519 in XRE_InitChildProcess(int, char**, XREChildData const*) src/toolkit/xre/nsEmbedFunctions.cpp:729:34
#83 0x5580681252f7 in content_process_main src/browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
#84 0x5580681252f7 in main src/browser/app/nsBrowserApp.cpp:327:18
#85 0x7fbfbae110b2 in __libc_start_main /build/glibc-sMfBJT/glibc-2.31/csu/../csu/libc-start.c:308:16
#86 0x558068100a7c in _start (/home/worker/builds/m-c-20220408214449-fuzzing-debug/firefox-bin+0x15a7c)

Flags: in-testsuite?

Tyson Smith [:tsmith]

Reporter

Comment 1

•

2 years ago

A Pernosco session is available here: https://pernos.co/debug/TKjBYencma399LEzqfg8uA/index.html

Bugmon [:jkratzer for issues]

Comment 2

•

2 years ago

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220412035701-0bcad14b3c3a.
The bug appears to have been introduced in the following build range:

Start: c712ec8864e2ebd4d363fefab6980ab68bff83fd (20220407213814)
End: 6a588f6d08f795ffc8594a01250e3ae3307bde92 (20220407220844)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c712ec8864e2ebd4d363fefab6980ab68bff83fd&tochange=6a588f6d08f795ffc8594a01250e3ae3307bde92

Keywords: regression

Whiteboard: [bugmon:bisected,confirmed]

Emilio Cobos Álvarez (:emilio)

Assignee

Updated

•

2 years ago

Flags: needinfo?(emilio)

Emilio Cobos Álvarez (:emilio)

Assignee

Comment 3

•

2 years ago

Attached file Bug 1764224 - Don't assert primary frame on printing docs. r=dholbert,#layout-reviewers — Details

ReplicateFixedFrames can create extra frames, but we don't particularly
care about this.

Phabricator Automation

Updated

•

2 years ago

Assignee: nobody → emilio

Status: NEW → ASSIGNED

Emilio Cobos Álvarez (:emilio)

Assignee

Updated

•

2 years ago

Flags: needinfo?(emilio)

BugBot [:suhaib / :marco/ :calixte]

Comment 4

•

2 years ago

:emilio, since this bug contains a bisection range, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

Emilio Cobos Álvarez (:emilio)

Assignee

Updated

•

2 years ago

Flags: needinfo?(emilio)

Regressed by: 1733232

BugBot [:suhaib / :marco/ :calixte]

Comment 5

•

2 years ago

Set release status flags based on info from the regressing bug 1733232

status-firefox100: --- → unaffected

status-firefox99: --- → unaffected

status-firefox-esr91: --- → unaffected

Pulsebot

Comment 6

•

2 years ago

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e5ef6644c60
Don't assert primary frame on printing docs. r=dholbert

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 7

•

2 years ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33616 for changes under testing/web-platform/tests

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Updated

•

2 years ago

Whiteboard: [bugmon:bisected,confirmed] → [bugmon:bisected,confirmed], [wptsync upstream]

Cristina Cozmuta (:CrissCozmuta)

Comment 8

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/4e5ef6644c60

Status: ASSIGNED → RESOLVED

Closed: 2 years ago

status-firefox101: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → 101 Branch

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 9

•

2 years ago

Upstream PR merged by moz-wptsync-bot

BugBot [:suhaib / :marco/ :calixte]

Updated

•

2 years ago

Has Regression Range: --- → yes

Bugmon [:jkratzer for issues]

Comment 10

•

2 years ago

Bugmon Analysis
Verified bug as fixed on rev mozilla-central 20220413094328-bc9d2af4c01e.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Status: RESOLVED → VERIFIED

status-firefox101: fixed → verified

Keywords: bugmon

testcase.html 2 years ago Tyson Smith [:tsmith] 173 bytes, text/html		Details
Bug 1764224 - Don't assert primary frame on printing docs. r=dholbert,#layout-reviewers 2 years ago Emilio Cobos Álvarez (:emilio) 48 bytes, text/x-phabricator-request		Details \| Review