Closed Bug 1764329 Opened 2 years ago Closed 2 years ago

Chat messages are not correctly grouped if system flag changes

Categories

(Thunderbird :: Instant Messaging, defect)

Desktop
All
defect

Tracking

(thunderbird100 fixed, thunderbird101 affected)

RESOLVED FIXED
101 Branch
Tracking Status
thunderbird100 --- fixed
thunderbird101 --- affected

People

(Reporter: freaktechnik, Assigned: freaktechnik)

Details

Attachments

(1 file)

When appending chat messages that have identical flags except for the system flag changing, we incorrectly group them. Instead, a change of the system flag should always start a new group. We have not seen this often, since usually system messages have a who that isn't attributed to a participant that can send normal messages.

Target Milestone: --- → 101 Branch

Pushed by nicolai@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/cfd847f2f3b8
Fix chat message grouping and replacement with system messages. r=clokep

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Comment on attachment 9271938 [details]
Bug 1764329 - Fix chat message grouping and replacement with system messages. r=clokep

[Approval Request Comment]
Regression caused by (bug #): possibly always been an issue, just never surfaced as much
User impact if declined: Chat messages might be displayed without a sender, or not collapse properly etc.
Testing completed (on c-c, etc.): tested on c-c, has a mochitest (applies to c-b)
Risk to taking this patch (and alternatives if risky): Messes a lot with how the conversation browser displays chat messages, but has automated tests as well as adding various measures to make the code more tolerant in general. The alternative is to wait a week for a whole new beta to be branched.

Attachment #9271938 - Flags: approval-comm-beta?

Comment on attachment 9271938 [details]
Bug 1764329 - Fix chat message grouping and replacement with system messages. r=clokep

[Triage Comment]
Approved for beta despite the risk ... because beta 101.0b1 is going to be a bit of big splash we hope, so better to find out now, than next week, if there are problems

Attachment #9271938 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: