1764349 - Properly clear data collected by the Network panel

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

In order to improve memory footprint and (perhaps) also fix memory leaks we should make sure that the Network panel properly clears all collected data. Keep in mind Browser Toolbox scenario as well we Web Toolbox scenario.

Honza

Comment 1

[Hubert Boma Manilla (:bomsy)]

To add more highlights to what needs to be done here:-

1. A configurable limit to the no of network resources kept, that should be enforced by the front end and server, needs to be added.
2. Enable the clearing of network resources on the server when we clear on the frontend.

The solution should be implemented at the framework level (resource commands and watcher) which allows the functionality to be applied to other resources in the future.

This bug is going. to focus on implementing and enabling for just network resources specifically.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1764349 - [devtools] Add framework capabilities to clear resources r=ochameau

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1764349 - [devtools] Add clear functionality for network resources r=ochameau

Depends on D148139

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1764349 - [devtools] Support clearing of root-resources r=ochameau

Depends on D148694

Comment 5

[Phabricator Automation]

Comment on attachment 9279444 [details]
Bug 1764349 - [devtools] Add framework capabilities to clear resources r=ochameau

Revision D148139 was moved to bug 1775084. Setting attachment 9279444 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9281821 [details]
Bug 1764349 - [devtools] Support clearing of root-resources r=ochameau

Revision D149635 was moved to bug 1775084. Setting attachment 9281821 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47dea14575f1
[devtools] Add clear functionality for network resources r=ochameau

Comment 8

[Atila Butkovits]

Backed out for failing devtools at browser_net_stacktraces-visibility.js

backout link: https://hg.mozilla.org/integration/autoland/rev/967884f572eb35e60a289cb8ed9798bcaf9d1e16

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=47dea14575f129361a670e92e459d433839a3c85&selectedTaskRun=bekq48kJROuOxvn8Jvobmg.0

Failure log: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=47dea14575f129361a670e92e459d433839a3c85&selectedTaskRun=bekq48kJROuOxvn8Jvobmg.0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dfcc06b697b
[devtools] Add clear functionality for network resources r=ochameau

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5dfcc06b697b