1764370 - Use NS_GET_IID instead of NS_DEFINE_IID for PRIVATE_IDBREQUEST_IID

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task)

Description

[Andrew McCreight [:mccr8]]

IndexedDB uses PRIVATE_IDBREQUEST_IID as a special internal IID when QIing. To actually use that IID, it uses NS_DEFINE_IID in each file that uses it. This has been the deprecated way to do this for 20 years or so, and this is the last remaining use of it in the tree. I've written a patch to replace the use of it with NS_DEFINE_IID by creating an empty class to hang the special IID off of. This is the same thing that the cycle collector does for its special interface, via the class nsCycleCollectionISupports.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1764370 - Use NS_GET_IID instead of NS_DEFINE_IID for PRIVATE_IDBREQUEST_IID.

Create a new fake class so that NS_GET_IID can be used instead of
NS_DEFINE_IID.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a81dca11365
Use NS_GET_IID instead of NS_DEFINE_IID for PRIVATE_IDBREQUEST_IID. r=dom-workers-and-storage-reviewers,asuth

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1a81dca11365