1764626 - Differentiate between about:welcome and Spotlight context when sending event telemetry

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

Rather than hard code the string "about:welcome" for the page value here, distinguish between the "spotlight" and "about:welcome" contexts.

Comment 1

[Meg Viar [:mviar]]

Attachment: Bug 1764626 - Differentiate between about:welcome and Spotlight context when sending event telemetry

Comment 3

[Meg Viar [:mviar]]

Disregard above - not a duplicate

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/252f5225f556
Differentiate between about:welcome and Spotlight context when sending event telemetry r=Mardak

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for causing bc failures on browser_multistage_spotlight.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=252f5225f55642952ec91540891fb85b8773a6a0&selectedTaskRun=U-DGjVAMRg-su0ch1McKHQ.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=375360133&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=375360165&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/8c6574515d51abe1c2e3b6f5f0230d8a1c989e28

Comment 6

[Meg Viar [:mviar]]

Thanks, Cosmin. I didn't run into this failure on the try server - I'll work on replicating and resolving the issue.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/392ddb43da5b
Differentiate between about:welcome and Spotlight context when sending event telemetry r=Mardak

Comment 8

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_multistage_spotlight_telemetry.js

Backout link

Push with failures

Failure log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95a3139b7690
Differentiate between about:welcome and Spotlight context when sending event telemetry r=Mardak

Comment 10

[Meg Viar [:mviar]]

The patch was updated to address the failure and the previously failing jobs now pass on Try.

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/95a3139b7690