1764663 - Git pre-commit hook does not respect working tree/index distinction

Status: NEW

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Description

[Ray Kraesig [:rkraesig]]

If multiple changes are made to a file, and some but not all of those changes are added to the index (as may be the case after running git add -p), then the pre-commit hook will destroy this distinction by silently adding all the remaining changes to the new commit as well.

Presumably this is what the TODO around line 90 is about.

(I think the ideal behavior here is to run clang-format-diff.py on git diff --cached, and if its output doesn't also apply cleanly to the working tree, just reject the commit. Unconditionally erroring in this state is probably an acceptable fallback, though.)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahal, could you have a look please?

For more information, please visit auto_nag documentation.