Closed Bug 1764673 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33635 - Convert 'triggerpopup' attribute to 'togglepopup'

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33635 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33635
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Convert 'triggerpopup' attribute to 'togglepopup'

Per the [1] resolution, OpenUI has decided to change from
'triggerpopup' to 'togglepopup', with the corresponding behavior
change that when the popup is already open, clicking the invoking
button again will cause the popup to be hidden.

[1] https://github.com/openui/open-ui/issues/508#issuecomment-1092081568

Bug: 1307772
Change-Id: I9a9720a2acb0c952173bed47424ffbbfc8144714
Reviewed-on: https://chromium-review.googlesource.com/3584778
WPT-Export-Revision: f505e18ccca12a8f5cd33301825f62a780c12005

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 9 subtests

Status Summary

Firefox

OK : 3
FAIL : 26
ERROR: 1

Chrome

OK : 3
PASS : 15
FAIL : 17
ERROR: 1

Safari

OK : 3
FAIL : 26
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/popups/popup-focus.tentative.html
Popup focus test: default behavior - popup is not focused: FAIL (Chrome: PASS, Safari: FAIL)
Popup focus test: autofocus popup: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus empty popup: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus popup with button: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus child: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus on tabindex=0 element: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus multiple children: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: autofocus popup and multiple autofocus children: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: delegatesfocus popup: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: delegatesfocus takes precedence over autofocus: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: delegatesfocus takes precedence over autofocus 2: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: delegatesfocus on empty popup has no effect: FAIL (Chrome: PASS, Safari: FAIL)
Popup focus test: delegatesfocus on child has no effect: FAIL (Chrome: PASS, Safari: FAIL)
Popup focus test: delegatesfocus skips contained popups: FAIL (Chrome: FAIL, Safari: FAIL)
Popup focus test: delegatesfocus skips contained dialogs: FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/popups/popup-invoking-attribute.tentative.html
Clicking a togglepopup button opens a closed popup: FAIL (Chrome: FAIL, Safari: FAIL)
Clicking a togglepopup button closes an open popup: FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/popups/popup-light-dismiss.tentative.html: ERROR (Chrome: ERROR, Safari: ERROR)
/html/semantics/popups/popup-stacking.tentative.html
Direct DOM children: FAIL (Chrome: PASS, Safari: FAIL)
Grandchildren: FAIL (Chrome: PASS, Safari: FAIL)
togglepopup attribute relationship: FAIL (Chrome: FAIL, Safari: FAIL)
nested togglepopup attribute relationship: FAIL (Chrome: FAIL, Safari: FAIL)
anchor attribute relationship: FAIL (Chrome: PASS, Safari: FAIL)
indirect anchor attribute relationship: FAIL (Chrome: PASS, Safari: FAIL)
more complex nesting, all using anchor ancestry: FAIL (Chrome: PASS, Safari: FAIL)
popups should be closed by dialogs: FAIL (Chrome: PASS, Safari: FAIL)
dialogs should not be closed by popups: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b891483551c
[wpt PR 33635] - Convert 'triggerpopup' attribute to 'togglepopup', a=testonly
https://hg.mozilla.org/integration/autoland/rev/e3c88d350b5a
[wpt PR 33635] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9b891483551c
https://hg.mozilla.org/mozilla-central/rev/e3c88d350b5a

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.