1764698 - i18n.detectLanguage API broken on all plattforms, except Firefox

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P5)

Description

[John Bieling (:TbSync)]

The i18n API lives in toolkit and is therefore used for multiple platforms. However, it loads
LanguageDetector.jsm 1 which exists only for Firefox 2. The function browser.i18n.detectLanguage() is therefore broken on all platforms, except Firefox. The tests on those other platforms are disabled 3.

Could that JSM or the entire translation folder be moved to toolkit as well?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Florian,
is LanguageDetector.jsm a JSM that we could technically be moved at toolkit level?

Comment 3

[Florian Quèze [:florian]]

(In reply to Luca Greco [:rpl] [:luca] [:lgreco] from comment #2)

is LanguageDetector.jsm a JSM that we could technically be moved at toolkit level?

That seems possible. You would also need to move the cld2 folder and the test/unit folder from the browser/components/translation folder to toolkit/.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #4)

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

This is blocking other work. At least S3.

Comment 6

[Tomislav Jovanovic :zombie]

Not a Firefox bug, but patches welcome for TB.

Comment 7

[Rob Wu [:robwu]]

Patches are welcome indeed. John - are you interested in contributing a patch?

Comment 8

[John Bieling (:TbSync)]

Yes, but i need another week, as I have my head in release related issues currently.

Comment 9

[John Bieling (:TbSync)]

Attachment: Bug 1764698 - Move LanguageDetector.jsm and related files to toolkit. r=robwu

Comment 10

[John Bieling (:TbSync)]

Attachment: Bug 1764698 - Move LanguageDetector.jsm and related files to toolkit. r=robwu

Comment 12

[John Bieling (:TbSync)]

Is there something wrong with my patch?

Comment 13

[Rob Wu [:robwu]]

I overlooked the review request.

Note that while the extension API is a consumer of this internal library, the LanguageDetector.jsm itself is part of Firefox::Translation, so you should also tag the owner of that component. Perhaps :florian?

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8828277a87e
Move LanguageDetector.jsm and related files to toolkit. r=robwu

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a8828277a87e