1764780 - Compose window missing CC/BCC buttons, padlock overlaps subject

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P3)

Description

[Kevin Locke]

Attachment: Screenshot of compose window in Thunderbird Daily build 20220412134817

With the current Thunderbird Daily (build 20220414095245) the Cc and Bcc buttons no longer appear in the compose window and a broken padlock icon overlaps the text in the Subject textbox. (See attached screenshot.)

I'm unable to reproduce the issue with a fresh profile. However, I can reproduce it in mozregression using a copy of my default profile:

Pushlog: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=621f68e7655f8f8d2b2cd12b4ea1d5bffb6e833a&tochange=07d360c5abe521727650d8ae7d802869dccf832a suggests this was regressed by Bug 1764324.

I'd be happy to test any suggestions for how to reproduce the issue in a fresh profile.

Comment 1

[Kevin Locke]

Attachment: (Good) Screenshot of compose window in Thunderbird Daily build 20220412100606

Here's a screenshot of the same compose window on build 20220412100606 for comparison.

Comment 2

[Kevin Locke]

Possibly related: When opening the compose window the following messages appear in the Error Log:

Uncaught (in promise) TypeError: can't access property "hidden", document.getElementById(...) is null
    adjustSignEncryptAfterIdentityChanged chrome://messenger/content/messengercompose/MsgComposeCommands.js:4488
    ComposeLoad chrome://messenger/content/messengercompose/MsgComposeCommands.js:4821

Comment 3

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/91923108c54cd5e574fbaeed2b6af0cbeee37d37/mail/components/compose/content/MsgComposeCommands.js#4488
I guess button-encryption-options isn't there.

Comment 4

[Thomas D. (:thomas8)]

S2 because not having CC/BCC disclosure buttons is quite a big fallout, regardless of the fact that the fix may be simple.

Comment 5

[Kevin Locke]

Thanks all for looking into this!

(In reply to Magnus Melin [:mkmelin] from comment #3)

https://searchfox.org/comm-central/rev/91923108c54cd5e574fbaeed2b6af0cbeee37d37/mail/components/compose/content/MsgComposeCommands.js#4488
I guess button-encryption-options isn't there.

Any idea why that might be? I noticed the "Encrypt" button adjacent to "Send" is present in a fresh profile, but not in my normal profile (as seen in the screenshots above). Is that a setting I've changed?

Comment 6

[Thomas D. (:thomas8)]

Kevin, did you customize your toolbar in any way, like adding buttons from Thunderbird's toolbar customization dialog?
Maybe if our migration code wasn't perfect, it might have tried to respect your customized toolbar set by not adding the encryption button, which then may have caused this error if I understand Magnus correctly...

Comment 7

[Richard Marti (:Paenglab)]

Here I see the same issue. After resetting the toolbar the Encrypt button appears and the CC/BCC buttons are back.

Bug 1764324 missed to do a migration of this toolbar to add the button and this bug here should be used to do this.
Also shouldn't it fail when the button is removed when a user doesn't want this button.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: Bug 1764780 - Handle migration of (and customized away) button-encryption and button-encryption-options. r=Paenglab

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c90dfb1bda98
handle migration (and customzed away) button-encryption and button-encryption-options. r=Paenglab