1764816 - Handle file://, blob: data: ip4/ip6 etc. URIs when displaying recent tabs in Firefox View

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Sam Foster [:sfoster] (he/him)]

There's a lot of different URI variations that we support in browser tabs that would break a naive implementation when displaying a concise version of that URI in the recent and synced tabs listing.

We should make a representative list and make sure we have test coverage to ensure each gets rendered with the expected result.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Sync' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Sammy Khamis [:skhamis]]

Sync has a pref that controls what type of schemes can be synced by tabs or send tab: https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#4349.

Comment 3

[Sam Foster [:sfoster] (he/him)]

(In reply to Sammy Khamis [:skhamis] from comment #2)

Sync has a pref that controls what type of schemes can be synced by tabs or send tab: https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#4349.

Huh. How does file:// work across devices? I assume it doesnt - unless we are talking about different profiles on the same machine.

The Firefox View specs show a eTLD+1 next to the title of the tab. Which isn't going to work obviously for blob/file/etc. So this bug is specifically for digging into that.

Some of the Firefox View bugs have ended up in Firefox::Sync as they deal explicitly with setting up Sync and using its services to get recent tabs on other devices. But the "Recently closed tabs" I think is going to be just for the current device & profile(?) So i'm not sure what the right bugzilla component is for now.

Comment 4

[Sammy Khamis [:skhamis]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #3)

(In reply to Sammy Khamis [:skhamis] from comment #2)

Sync has a pref that controls what type of schemes can be synced by tabs or send tab: https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#4349.

Huh. How does file:// work across devices? I assume it doesnt - unless we are talking about different profiles on the same machine.

The Firefox View specs show a eTLD+1 next to the title of the tab. Which isn't going to work obviously for blob/file/etc. So this bug is specifically for digging into that.

Some of the Firefox View bugs have ended up in Firefox::Sync as they deal explicitly with setting up Sync and using its services to get recent tabs on other devices. But the "Recently closed tabs" I think is going to be just for the current device & profile(?) So i'm not sure what the right bugzilla component is for now.

Yes file:// doesn't work across devices and thus we don't sync it. Thanks for the context on it being in the Sync component! Seems to make sense for now and won't affect current tab syncs.

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1764816 - handle esoteric URLs in Firefox View (blob/file/data/ip addresses), r?sfoster,sclements

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daf94a369b2a
handle esoteric URLs in Firefox View (blob/file/data/ip addresses), r=sfoster,sclements,fluent-reviewers,jaws

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/daf94a369b2a