1764885 - Broken MDN icon for HTTP Headers

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Screenshot (99/101)

It looks MDN icon (learn more) for HTTP headers changed it's style. Regression?

STRs:

1. Open DevTools and select the Console panel (make sure the XHR filter is on)
2. Load http://janodvarko.cz/firebug/tests/601/Issue601.htm
3. Click the POST button to generate XHR request
4. Expand the request and check out the (questionmark) MDN icon, the style has changed -> BUG

I am attaching a screenshot showing the difference between the style now and before (in the Console panel)

The similar problem is visible in the Network Headers side panel too.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Nicolas, Bomsy, do you know what could cause this?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

maybe something I did cleaning up CSS , I think it even came during the review and I might have forget to fix it? I'll check that

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1764885 - [devtools] Fix network MDN icon for HTTP Headers. r=Honza.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1762550

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f354a3f89c5
[devtools] Fix network MDN icon for HTTP Headers. r=Honza.

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0f354a3f89c5

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9272460 [details]
Bug 1764885 - [devtools] Fix network MDN icon for HTTP Headers. r=Honza.

Beta/Release Uplift Approval Request

• User impact if declined: Broken Console network styling
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See https://bugzilla.mozilla.org/show_bug.cgi?id=1764885#c0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS Change only
• String changes made/needed:

Comment 8

[Peter Magyari (Desktop QA)]

I've reproduced the issue on Nightly 101.0a1 (20220418213528) and verified the fix on Nightly 101.0a1 (20220419214607)

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9272460 [details]
Bug 1764885 - [devtools] Fix network MDN icon for HTTP Headers. r=Honza.

Approved for 100.0b9

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e5a26240a71a

Comment 11

[Peter Magyari (Desktop QA)]

Verified the fix on Beta 100.0b9 (20220420161007)