Closed Bug 1764915 Opened 3 years ago Closed 3 years ago

Crash [@ _M_ptr]

Categories

(Core :: WebRTC, defect, P1)

Product:
Core
Component:
WebRTC
Platform:
x86_64
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox99 --- unaffected
firefox100 --- unaffected
firefox101 --- verified

People

(Reporter: jkratzer, Assigned: bwc)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, testcase, Whiteboard: [bugmon:bisected,confirmed])

Crash Data

Attachments

(3 files)

Testcase
257 bytes, text/plain
Details
Bug 1764915: Test-case for bug. r?jib
48 bytes, text/x-phabricator-request
Details | Review
Bug 1764915: Make sure we set the certificate even if the PC is closed. r?jib
48 bytes, text/x-phabricator-request
Details | Review

Testcase found while fuzzing mozilla-central rev 7f6fc25d231f (built with: --enable-address-sanitizer --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build 7f6fc25d231f --asan --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html

[@ _M_ptr]

    =================================================================
    ==2071763==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000040 (pc 0x7f60ec35dd74 bp 0x7fffffb0b0d0 sp 0x7fffffb0b0b0 T0)
    ==2071763==The signal is caused by a READ memory access.
    ==2071763==Hint: address points to the zero page.
        #0 0x7f60ec35dd74 in _M_ptr /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/unique_ptr.h:147:42
        #1 0x7f60ec35dd74 in get /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/unique_ptr.h:332:21
        #2 0x7f60ec35dd74 in operator-> /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/unique_ptr.h:326:9
        #3 0x7f60ec35dd74 in mozilla::DtlsIdentity::ComputeFingerprint(std::unique_ptr<CERTCertificateStr, mozilla::UniqueCERTCertificateDeletePolicy> const&, mozilla::DtlsDigest*) /dom/media/webrtc/transport/dtlsidentity.cpp:320:31
        #4 0x7f60f12f2084 in mozilla::PeerConnectionImpl::CalculateFingerprint(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<unsigned char, std::allocator<unsigned char> >*) const /dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:1923:17
        #5 0x7f60f130244a in mozilla::PeerConnectionImpl::GetFingerprint(char**) /dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:1938:17
        #6 0x7f60ee461415 in mozilla::PeerConnectionImpl::GetFingerprint(nsTSubstring<char16_t>&) /dom/media/webrtc/jsapi/PeerConnectionImpl.h:333:19
        #7 0x7f60ee461245 in mozilla::dom::PeerConnectionImpl_Binding::get_fingerprint(JSContext*, JS::Handle<JSObject*>, void*, JSJitGetterCallArgs) /builds/worker/workspace/obj-build/dom/bindings/PeerConnectionImplBinding.cpp:1061:24
        #8 0x7f60ef760044 in bool mozilla::dom::binding_detail::GenericGetter<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /dom/bindings/BindingUtils.cpp:3152:13
        #9 0x7f60f97895b4 in CallJSNative /js/src/vm/Interpreter.cpp:420:13
        #10 0x7f60f97895b4 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:507:12
        #11 0x7f60f978b2db in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:584:8
        #12 0x7f60f7ed337d in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /js/src/vm/CallAndConstruct.cpp:117:10
        #13 0x7f60ec0fc424 in Call /builds/worker/workspace/obj-build/dist/include/js/CallAndConstruct.h:110:10
        #14 0x7f60ec0fc424 in xpc::XrayWrapper<js::CrossCompartmentWrapper, xpc::DOMXrayTraits>::get(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::Handle<JS::PropertyKey>, JS::MutableHandle<JS::Value>) const /js/xpconnect/wrappers/XrayWrapper.cpp:2073:10
        #15 0x7f60f84bc9f9 in getInternal /js/src/proxy/Proxy.cpp:479:19
        #16 0x7f60f84bc9f9 in js::Proxy::get(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::Handle<JS::PropertyKey>, JS::MutableHandle<JS::Value>) /js/src/proxy/Proxy.cpp:487:10
        #17 0x7f60f84bcb14 in getInternal /js/src/proxy/Proxy.cpp:475:14
        #18 0x7f60f84bcb14 in js::Proxy::get(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::Handle<JS::PropertyKey>, JS::MutableHandle<JS::Value>) /js/src/proxy/Proxy.cpp:487:10
        #19 0x7f60f7dcca66 in GetProperty /js/src/vm/ObjectOperations-inl.h:117:12
        #20 0x7f60f7dcca66 in js::GetProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, js::PropertyName*, JS::MutableHandle<JS::Value>) /js/src/vm/ObjectOperations-inl.h:127:10
        #21 0x7f60f9790764 in js::GetProperty(JSContext*, JS::Handle<JS::Value>, JS::Handle<js::PropertyName*>, JS::MutableHandle<JS::Value>) /js/src/vm/Interpreter.cpp:4658:10
        #22 0x7f60f976015a in GetPropertyOperation /js/src/vm/Interpreter.cpp:203:10
        #23 0x7f60f976015a in Interpret(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:2963:12
        #24 0x7f60f975adf1 in js::RunScript(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:389:13
        #25 0x7f60f97896ef in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:539:13
        #26 0x7f60f978b2db in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:584:8
        #27 0x7f60f8258a17 in js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) /js/src/vm/SelfHosting.cpp:1590:10
        #28 0x7f60f7e9afd9 in AsyncFunctionResume(JSContext*, JS::Handle<js::AsyncFunctionGeneratorObject*>, ResumeKind, JS::Handle<JS::Value>) /js/src/vm/AsyncFunction.cpp:152:8
        #29 0x7f60f8161b8a in AsyncFunctionPromiseReactionJob /js/src/builtin/Promise.cpp:1949:12
        #30 0x7f60f8161b8a in PromiseReactionJob(JSContext*, unsigned int, JS::Value*) /js/src/builtin/Promise.cpp:2012:12
        #31 0x7f60f97895b4 in CallJSNative /js/src/vm/Interpreter.cpp:420:13
        #32 0x7f60f97895b4 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:507:12
        #33 0x7f60f978b2db in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:584:8
        #34 0x7f60f7ed337d in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /js/src/vm/CallAndConstruct.cpp:117:10
        #35 0x7f60ee5601ac in mozilla::dom::PromiseJobCallback::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/PromiseBinding.cpp:35:8
        #36 0x7f60ea5a9777 in Call /builds/worker/workspace/obj-build/dist/include/mozilla/dom/PromiseBinding.h:89:12
        #37 0x7f60ea5a9777 in Call /builds/worker/workspace/obj-build/dist/include/mozilla/dom/PromiseBinding.h:102:12
        #38 0x7f60ea5a9777 in mozilla::PromiseJobRunnable::Run(mozilla::AutoSlowOperation&) /xpcom/base/CycleCollectedJSContext.cpp:213:18
        #39 0x7f60ea588a87 in mozilla::CycleCollectedJSContext::PerformMicroTaskCheckPoint(bool) /xpcom/base/CycleCollectedJSContext.cpp:674:17
        #40 0x7f60ea589a6f in mozilla::CycleCollectedJSContext::AfterProcessTask(unsigned int) /xpcom/base/CycleCollectedJSContext.cpp:463:3
        #41 0x7f60ec1bafe6 in XPCJSContext::AfterProcessTask(unsigned int) /js/xpconnect/src/XPCJSContext.cpp:1483:28
        #42 0x7f60ea7cd938 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1217:24
        #43 0x7f60ea7d714c in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:465:10
        #44 0x7f60ebee798f in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:85:21
        #45 0x7f60ebd61971 in RunInternal /ipc/chromium/src/base/message_loop.cc:380:10
        #46 0x7f60ebd61971 in RunHandler /ipc/chromium/src/base/message_loop.cc:373:3
        #47 0x7f60ebd61971 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:355:3
        #48 0x7f60f2be7fa7 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:137:27
        #49 0x7f60f7a7e0af in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:870:20
        #50 0x7f60ebd61971 in RunInternal /ipc/chromium/src/base/message_loop.cc:380:10
        #51 0x7f60ebd61971 in RunHandler /ipc/chromium/src/base/message_loop.cc:373:3
        #52 0x7f60ebd61971 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:355:3
        #53 0x7f60f7a7d2d3 in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:729:34
        #54 0x56235494c47d in content_process_main(mozilla::Bootstrap*, int, char**) /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #55 0x56235494c8b0 in main /browser/app/nsBrowserApp.cpp:327:18
        #56 0x7f610f5470b2 in __libc_start_main /build/glibc-sMfBJT/glibc-2.31/csu/../csu/libc-start.c:308:16
        #57 0x56235489b569 in _start (/home/jkratzer/builds/mc-asan/firefox+0x5e569)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/unique_ptr.h:147:42 in _M_ptr
    ==2071763==ABORTING
Attached file Testcase —

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220415092909-7f6fc25d231f.
The bug appears to have been introduced in the following build range:

Start: 7fac8607d414d792f4530b726f68ad36afb3c545 (20220405212313)
End: 5135fb6675eacd4e4aa46983b4c7821f678544a6 (20220405205608)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7fac8607d414d792f4530b726f68ad36afb3c545&tochange=5135fb6675eacd4e4aa46983b4c7821f678544a6

Keywords: regression
Whiteboard: [bugmon:confirm] → [bugmon:bisected,confirmed]
Crash Signature: [@ _M_ptr] → [@ _M_ptr] [@ mozilla::DtlsIdentity::ComputeFingerprint ]

A common denominator of all these test cases seem to be that they're relying on the operations chain to keep objects alive...

Severity: -- → S3
Priority: -- → P2
Regressed by: 1616937, 1624989
See Also: → 1764940, 1764933
Severity: S3 → S2
Assignee: nobody → docfaraday
Priority: P2 → P1

There is nothing in the spec that says getIdentityAssertion is supposed to
fail if the PC is closed.

Depends on D143953

Has Regression Range: --- → yes
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/177387e6fdb1 Test-case for bug. r=jib https://hg.mozilla.org/integration/autoland/rev/606d60cb9c88 Make sure we set the certificate even if the PC is closed. r=jib

https://hg.mozilla.org/mozilla-central/rev/177387e6fdb1
https://hg.mozilla.org/mozilla-central/rev/606d60cb9c88

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch

Bugmon Analysis
Verified bug as fixed on rev mozilla-central 20220420215300-a33cd50e2f73.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Status: RESOLVED → VERIFIED
status-firefox101: fixed → verified
Keywords: bugmon
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: