Closed Bug 1765176 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33669 - Delay setting `--adb-binary` default

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox102 fixed)

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33669 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33669
Details from upstream follow.

Jonathan Lee <jonathanjlee@google.com> wrote:

Delay setting --adb-binary default

The change #33654 caused chrome_android-related runs without --adb-binary to fail because the corresponding kwarg was None but present. Constructing the browser overwrote the kwarg default.

This change fixes that bug by using None to signal default adb usage.

This time, I tested the change on the run_monochrome_webview_finch_smoke_tests target in Chromium as well, which does not pass --adb-binary to wptrunner.

PR 33669 applied with additional changes from upstream: f7ffbe169709718407b31770075d47dbf4e9222f
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f757806d413
[wpt PR 33669] - Use `None` to signal `adb` binary default for `chrome_android`-related products, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1f757806d413

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.