Cleanup: Add OPAQUE1 to kRemoteCalculatedStates
Categories
(Core :: Disability Access APIs, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: Jamie, Assigned: Jamie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
As suggested in this comment, we should add states::OPAQUE1 to [kRemoteCalculatedStates]https://searchfox.org/mozilla-central/rev/2c4522f76b23b024d9f29e140d41042853874c07/accessible/base/States.h#298). This would mean we could always use Opacity() for this state; it would never get included in the initial cache push. We'd do this by just removing this else block.
This will have no user impact; it's purely code cleanup.
|
Assignee | |
Comment 1•2 years ago
|
||
This state is derived based on Accessible::Opacity, which is implemented for both local and remote Accessibles.
Thus, we can use common code to calculate this state.
As part of this, OPAQUE1 was added to kRemoteCalculatedStates so that it isn't included in the initial cache push, which also means we don't have to remove it later.
This patch also tweaks the test to flush layout so that the opacity change takes effect immediately in that process.
This is necessary to avoid a (graceful) timeout in untilCacheOk for non-caching tests, since there is no cache update to make untilCacheOk return before the timeout.
|
||
Updated•2 years ago
|
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f88096c30893 Move OPAQUE1 state calculation into Accessible::ApplyImplicitState. r=morgan
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Description
•