Open Bug 1765222 Opened 3 years ago Updated 3 years ago

nsDataObj::m_enumFE and nsDataObj::mDataFlavors are not parallel arrays

Categories

(Core :: Widget: Win32, defect, P3)

Product:
Core
Component:
Widget: Win32
Platform:
Unspecified
Windows
Type:
defect

Tracking

()

People

(Reporter: handyman, Unassigned)

References

Details

nsDataObj::m_enumFE and nsDataObj::mDataFlavors are used as if they are parallel arrays and I believe they were until bug 513464 changed nsDataObjCollection::AddDataFlavor by removing only its mDataFlavors insertion. We still clearly traverse the arrays with the expectation that their entries line up -- see for example nsDataObj::GetData. I do not know of any issues this has produced.

I don't see how the lists should not align. I think the parallel arrays should be consolidated into one. It's far too easy to overlook otherwise -- for example, the proposed patch in bug 557708 made this assumption.

Severity: -- → S3
Priority: -- → P3
Blocks: 557708
You need to log in before you can comment on or make changes to this bug.