Closed Bug 1765331 Opened 2 years ago Closed 2 years ago

nsDisplayRemote doesn't account for object-fit/position correctly.

Categories

(Core :: Web Painting, defect)

Product:
Core
Component:
Web Painting
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1765331 - Account for dest rect correctly in nsDisplayRemote painting. r=tnikkel
48 bytes, text/x-phabricator-request
Details | Review

While the subdocument sizing gets accounted for in GetSubdocumentSize(), positioning doesn't.

The in-process code does this here:

https://searchfox.org/mozilla-central/rev/4b3039b48c3cb67774270ebcc2a7d8624d888092/layout/generic/nsSubDocumentFrame.cpp#729-742

This doesn't do much for regular iframes because they have no meaningful
intrinsic ratio, but this will matter for bug 1595491.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d53e0ca638d
Account for dest rect correctly in nsDisplayRemote painting. r=tnikkel
Attachment #9272829 - Attachment description: Bug 1765331 - Account for dest rect correctly in nsDisplayRemote painting. r=miko,jrmuizel,tnikkel → Bug 1765331 - Account for dest rect correctly in nsDisplayRemote painting. r=tnikkel
Blocks: 1765496
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa3aeaf4ef92
Account for dest rect correctly in nsDisplayRemote painting. r=tnikkel
Flags: needinfo?(emilio)

https://hg.mozilla.org/mozilla-central/rev/aa3aeaf4ef92

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.