1765396 - NativeLayerCA should not block HDR video playback on `gfx.core-animation.specialize-video` pref

Status: VERIFIED FIXED

(Core :: Graphics, defect, P2)

Description

[Brad Werth [:bradwerth]]

NativeLayerCA::ShouldSpecializeVideo checks this pref before it checks to see if the video is HDR. We don't want the pref to turn off HDR support, so this logic should be reordered.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1765396: Make macOS always use specialized video layers for HDR video.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e621c0f4e0da
Make macOS always use specialized video layers for HDR video. r=mstange

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e621c0f4e0da

Comment 4

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Nightly 101.0a1 (2022-04-20) (build id: 20220420094247). HDR videos are rendered accordingly in HDR, with gfx.core-animation.specialize-video set to false as well.

Comment 5

[Vassili Koss]

Hey thanks for the super helpful reply. I'm not sure how I missed that thread. I haven't quite mastered the search function on here. I think I'll pass with him this time around. If i want any further guideline we will contact you here https://bugzilla.mozilla.org/show_bug.cgi?id=1765396 https://teatimeresults.co/.
Thanks

Comment 6

[Dianna Smith [:diannaS]]

can you nominate this for an uplift based on bug 1763782?

Comment 7

[Brad Werth [:bradwerth]]

Comment on attachment 9272899 [details]
Bug 1765396: Make macOS always use specialized video layers for HDR video.

Beta/Release Uplift Approval Request

• User impact if declined: macOS HDR video will not be displayed correctly in Beta or Release.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch just eliminates the unintended influence of a pref.
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9272899 [details]
Bug 1765396: Make macOS always use specialized video layers for HDR video.

Approved for 100.0b9

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/81484a33992b

Comment 10

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Beta 100.0 (build id: 20220425210429). HDR videos are rendered accordingly in HDR with gfx.core-animation.specialize-video set to false.

Comment 11

[malik Shaffi]

I totally agreed with you my problem is solved completely. Thankyou so much https://doradotarde.com/
Have a nice day to all…

Comment 12

[Bens Arman]

Here are the common codecs that are required to play HDR video: HEVC. You'll need this codec and a premium subscription to play HDR video on Netflix. To determine if this codec is installed, open Settings, select Apps > Apps & features, then search for video extension. For more detail also see https://bugzilla.mozilla.org/ https://sinuanonoche.com/ https://10eloto.com/

Comment 13

[Bens Arman]

And also tells about https://gosloto.co/uk-49s-lunchtime-results/