1765423 - Tooltips now have yellow background instead of white

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Kagami [:saschanaz] (they/them)]

Attachment: image.png

I guess this is not an intended change per the description in https://phabricator.services.mozilla.com/D143754 ?

On regular (non-HCM) Windows 10+ we just fill a rect with infobackground color
and so on, so there shouldn't be any effective behavior change.

It did introduce a change, so filing a bug. Maybe a chance to introduce dark mode to tooltips 😄

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1757797

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1757797, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

That matches the native tooltips that already existed in the restore buttons and other applications, so even tho it was not directly intentional, it's it's pretty much a progression.

In terms of introducing dark mode support to tooltips, there's already a proton tooltips pref that does that's but it's not enabled by default. We could also add non-native theme support for the tooltip theme colors, but that would be inconsistent with the restore window tooltips and so.

Dao do you know the state of the proton tooltip pref? Presumably nobody is working on it? Maybe it could be cleaned up and we could improve a bit all the tooltips instead.

Comment 4

[Itiel]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

That matches the native tooltips that already existed in the restore buttons and other applications ...

Only the window control buttons are yellow natively on Windows (on other apps and for native apps like File Explorer), any other tooltips are white afaict.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Dao do you know the state of the proton tooltip pref? Presumably nobody is working on it? Maybe it could be cleaned up and we could improve a bit all the tooltips instead.

I haven't heard of any plans to do that and don't know what it would take, so I would rather not count on that to fix this bug.

Can we just switch to background-color: window and color: windowtext on Windows? Perhaps only for @media (-moz-windows-default-theme) if we still want the info color for high contrast?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1765423 - Use Window/WindowText for tooltips in the default Windows theme. r=dao

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Sure, that works. I'll send another patch which looks slightly nicer as well.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1765423 - Make tooltips look nicer with default window themes. r=dao

For that, make the Windows rounded-rect code apply to tooltips as well.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9b71e18f873
Use Window/WindowText for tooltips in the default Windows theme. r=dao
https://hg.mozilla.org/integration/autoland/rev/34a84ab2978a
Make tooltips look nicer with default window themes. r=dao

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b9b71e18f873
https://hg.mozilla.org/mozilla-central/rev/34a84ab2978a

Comment 11

[:Gijs (he/him)]

Should we uplift this?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Probably along bug 1767815.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9274813 [details]
Bug 1765423 - Make tooltips look nicer with default window themes. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: Tooltips look ugly-ish on Win10/11.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: Bug 1767815
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS change.
• String changes made/needed: none
• Is Android affected?: No

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9274807 [details]
Bug 1765423 - Use Window/WindowText for tooltips in the default Windows theme. r=dao

Approved for 101.0b5.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4ff01ae81eb6
https://hg.mozilla.org/releases/mozilla-beta/rev/22a561f0061d

Comment 16

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build (2022-04-19) on Windows 10 x64.
Verified as fixed on Firefox 101.0b5 (20220510144626) and Firefox 102.0a1 (20220510213954) on Windows 10 x64 and Windows 11.

Comment 17

[Ali]

Tooltips seem to be less defined and harder to read with this change.
Where they previously had a light background and black border; they now have a darker background and grey border.

100:

101.0b5:

Comment 18

[Ali]

Attachment: old-tooltip.jpg

Comment 19

[Ali]

Attachment: new-tooltip.jpg