Move the cancel icon used by about:newtab to the shared icon library in toolkit/themes/shared/icons
Categories
(Firefox :: New Tab Page, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: sfoster, Assigned: arjunkrishnababu96, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=css])
Attachments
(1 file)
browser/components/newtab/data/content/assets/glyph-cancel-16.svg is a variation of /toolkit/themes/shared/icons/close.svg. I think it makes most sense to move glyph-cancel-16.svg to live alongside the existing icon in the toolkit icon library. It should be named close-fill.svg.
Your patch should:
hg mv(or git equivalent) the file atbrowser/components/newtab/data/content/assets/glyph-cancel-16.svgtotoolkit/themes/shared/icons/close-fill.svg. This way we keep version history.- You will need to update the
toolkit/themes/shared/desktop-jar.inc.mnmanifest (please maintain alphabetical sorting) to include the new .svg - You'll need to find and update all references to point at
chrome://global/skin/icons/close-fill.svg - See the docs for hacking on newtab for details on how to edit CSS and refresh the bundle
You should always build and run with your changes to verify them. In this case I'm not sure there is an easy way to see the .icon-clear-input class in use, but you can check that chrome://global/skin/icons/close-fill.svg resolves to the correct icon when entered into the url bar.
|
Assignee | |
Comment 1•2 years ago
|
||
I'd like to work on this.
|
|
Assignee | |
Comment 2•2 years ago
|
||
This was done because the existing cancel icon (browser/components/newtab/data/content/assets/glyph-cancel-16.svg) is a variation of the (/toolkit/themes/shared/icons/close.svg) in the toolkil icon library and it makes sense for the former to live alongside the latter.
|
||
Updated•2 years ago
|
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f58543c27938 Move the cancel icon used by about:newtab to the shared icon library in toolkit/themes/shared/icons r=sfoster,desktop-theme-reviewers
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Description
•