Closed Bug 1765598 Opened 2 years ago Closed 7 months ago

Remove maximized Windows widget padding only needed for Windows 7 and 8.1

Categories

(Core :: Widget: Win32, task, P3)

Product:
Core
Component:
Widget: Win32
Platform:
Unspecified
Windows
Type:
task

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: handyman, Unassigned)

References

(Blocks 1 open bug)

Details

Bug 1614218 makes the Windows widget padding behavior of a maximized window compensate for an issue in the Windows function DwmDefWindowProc where window buttons (min, max, close) are ignored when the window's client region lines up with the screen dimensions (first seen in bug 618353). This is not an issue with the browser since Windows 10, where we draw and handle the window buttons ourselves. OTOH, the padding caused an issue on Win10+, so the padding is not used there.

The padding is added in nsNativeThemeWin::GetWidgetPadding and the client region consumes it in nsWindow::UpdateNonClientMargin. Many more details in bug 618353 and bug 1614218.

We should remember to delete this padding when we no longer need to support versions before Windows 10.

Severity: -- → S3
Priority: -- → P3

(In reply to David Parks [:handyman] from comment #0)

We should remember to delete this padding when we no longer need to support versions before Windows 10.

We can fix this bug now because Firefox versions >= 116 no longer support Windows versions < 10.

Blocks: win7-eol
Summary: Maximized Windows widget padding is only needed for Windows 7 and 8.1 → Remove maximized Windows widget padding only needed for Windows 7 and 8.1

I think this might have already been done in other bugs now? Bug 1844242 maybe.

Flags: needinfo?(emilio)

Yes

Status: NEW → RESOLVED
Closed: 7 months ago
Flags: needinfo?(emilio)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.