Closed Bug 1765627 Opened 2 years ago Closed 2 years ago

Add more assertions for DeviceInputConsumerTrack's ConnectDeviceInput and DisconnectDeviceInput

Categories

(Core :: Audio/Video: MediaStreamGraph, task, P1)

Product:
Core
Component:
Audio/Video: MediaStreamGraph
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

Details

Attachments

(1 file)

Bug 1765627 - Make sure {Disc, C}onnectDeviceInput are correctly called
48 bytes, text/x-phabricator-request
Details | Review

We can add more assertions to check

  1. DeviceInputConsumerTrack won't connect DeviceInputTrack without disconnecting the original one first
  2. The DeviceInputTrack is only set if the AudioDataListener is set as well

Add some assertions to make sure the ConnectDeviceInput and
DisconnectDeviceInput are called at the right time.

Blocks: 1765216
Pushed by cchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52b93d9f82e2
Make sure {Disc, C}onnectDeviceInput are correctly called r=padenot

https://hg.mozilla.org/mozilla-central/rev/52b93d9f82e2

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: