1765748 - Change SplitView to be less generic and better suits the style editor

Status: RESOLVED FIXED

(DevTools :: Style Editor, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

As the component was meant to be shared, there are options that are not relevant in the case of the styleeditor.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1765748 - [devtools] Remove unused SplitView#activeDetails. r=ochameau.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1765748 - [devtools] Remove unused SplitView#isLandscape . r=ochameau.

This allows us to remove the _mql property as well as the LANDSCAPE_MEDIA_QUERY
const.

Depends on D144263

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1765748 - [devtools] Turn SplitView.getSummaryElementByOrdinal into a private method. r=ochameau.

Depends on D144264

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1765748 - [devtools] Remove unused SplitView#appendItem options. r=ochameau.

onHide and onDestroy aren't declared from the callsite, we can remove them.

Depends on D144265

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1765748 - [devtools] Remove SplitView#appendItem onCreate option. r=ochameau.

Since there's nothing asynchronous happening before the item gets added to the
list, the consumer can directly use the properties of the object returned by
'appendTemplatedItem'.

Depends on D144266

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1765748 - [devtools] Simplify SplitView#appendItem onShow option. r=ochameau.

Only the detail element was needed in the callback, so we remove all the other
unnecessary parameters.
This allows us to also remove the data option.

Depends on D144267

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1765748 - [devtools] Merge SplitView appendTemplateItem and appendItem. r=ochameau.

The template nodes are retrieved and cached from the constructor so we don't have
to do it for every item we add.

Depends on D144268

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1765748 - [devtools] Remove SplitView active summary getter and rename setter. r=ochameau.

Depends on D144269

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1765748 - [devtools] Remove unncessary complex SplitView#setItemClassName. r=jdescottes.

The function was setting extra classes on both
the summary and the detail, running extra checks
to not remove the base classes.
It's only called from one place, and we only care
about adding classes to the summary element, which
we have access to directly.
We're switching to classList.(add|remove) , which
allows us to get rid of the SplitView method.

Depends on D144302

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ce2401d91c6
[devtools] Remove unused SplitView#activeDetails. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/9b88df83cf78
[devtools] Remove unused SplitView#isLandscape . r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/14bcdcb5e940
[devtools] Turn SplitView.getSummaryElementByOrdinal into a private method. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/866b20a6bb09
[devtools] Remove unused SplitView#appendItem options. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/87a35f35fa9a
[devtools] Remove SplitView#appendItem onCreate option. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/e2b89c9ab773
[devtools] Simplify SplitView#appendItem onShow option. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/1d349aa089bc
[devtools] Merge SplitView appendTemplateItem and appendItem. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/ae9861178cd1
[devtools] Remove SplitView active summary getter and rename setter. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/b454dd94245d
[devtools] Remove unncessary complex SplitView#setItemClassName. r=jdescottes.

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5ce2401d91c6
https://hg.mozilla.org/mozilla-central/rev/9b88df83cf78
https://hg.mozilla.org/mozilla-central/rev/14bcdcb5e940
https://hg.mozilla.org/mozilla-central/rev/866b20a6bb09
https://hg.mozilla.org/mozilla-central/rev/87a35f35fa9a
https://hg.mozilla.org/mozilla-central/rev/e2b89c9ab773
https://hg.mozilla.org/mozilla-central/rev/1d349aa089bc
https://hg.mozilla.org/mozilla-central/rev/ae9861178cd1
https://hg.mozilla.org/mozilla-central/rev/b454dd94245d