Closed Bug 1765873 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33740 - [@scope] Evaluate scoped rules in SelectorChecker

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33740 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33740
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@scope] Evaluate scoped rules in SelectorChecker

This CL propagates the enclosing StyleScope (if any) to
SelectorChecker, such that we can perform an additional check
(CheckInStyleScope) to see if the subject element is in scope.

Several different approaches were considered, but in order to remain
agile with regards to the different paths the css-cascade-6
specification might take from this point, I opted to handle it
entirely within SelectorChecker, even if other approaches may be
more efficient. It is more important that the prototype is able to
handle alternative entry points to the feature (if needed) than it
is to have the best possible performance right away.

Many performance optimizations are planned as follow-ups, most
notably:

  • Making use of the fast reject filter.
  • Multiple StyleScopeFrames with longer lifetimes.

Note also that addressing the following is deferred to future CLs:

  • ShadowDOM
  • Invalidation

Bug: 1280240
Change-Id: I050e7d8249688ae6d6d67431dceca5eabfbcc7fc

Reviewed-on: https://chromium-review.googlesource.com/3582131
WPT-Export-Revision: a5f7030d1968499873417393bd90dfa9ba03fa88

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e66b18d2287a
[wpt PR 33740] - [@scope] Evaluate scoped rules in SelectorChecker, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a7ca0dd20f33
[wpt PR 33740] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e66b18d2287a
https://hg.mozilla.org/mozilla-central/rev/a7ca0dd20f33

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.