Closed Bug 1765895 Opened 3 years ago Closed 3 years ago

Make presshellId start from 1 instead of 0

Categories

(Core :: Panning and Zooming, defect)

defect

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(2 files)

Timothy pointed me out that 0 presshellId is valid. We should allow it in APZTaskRunnable.

Assignee: nobody → hikezoe.birchill
Status: NEW → ASSIGNED
Attachment #9273336 - Attachment description: Bug 1765895 - Handle 0 presshellId as valid in APZTaskRunnable. r?tnikkel → Bug 1765895 - Make presshellId start from 1 rather than 0. r?tnikkel

Timothy also pointed out that we should just start the id from 1. I found there's at least one use case where we handle 0 presshellId as invalid here. So, yeah Timothy's suggestion makes quite sense and it will less error-prone.

Summary: Handle 0 presshellId as valid → Make presshellId start from 1 instead of 0
Pushed by hikezoe.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06e54ffb69cf s/IsRegistereddWithCurrentPresShell/IsRegisteredWithCurrentPresShell. r=tnikkel https://hg.mozilla.org/integration/autoland/rev/3b42d0b305d9 Make presshellId start from 1 rather than 0. r=tnikkel
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: