Closed
Bug 1765919
Opened 2 years ago
Closed 2 years ago
Rename toolkit/components/crashes/CrashManager.jsm.in to CrashManager.in.jsm
Categories
(Toolkit :: Crash Reporting, task)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
101 Branch
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
toolkit/components/crashes/CrashManager.jsm.in isn't checked by eslint because it has .jsm.in extension
The eslint rule needs to reflect it.
|
||
Comment 1•2 years ago
|
||
Could we rename it to CrashManager.in.jsm instead? It seems like it is all valid js, so with that naming, you'd get in-editor validation & source highlighting for free as well.
|
Assignee | |
Comment 2•2 years ago
|
||
Sounds good :D
Summary: Make toolkit/components/crashes/CrashManager.jsm.in target of JSM eslint rule → Rename toolkit/components/crashes/CrashManager.jsm.in to CrashManager.in.jsm
|
|
||
Updated•2 years ago
|
Component: General → Crash Reporting
|
|
Assignee | |
Comment 3•2 years ago
|
||
CRASH_MANAGER_PROCESS_PINGS is modified to substitute only the properties of
the object, in order to let eslint use the processPings local variable while
linting CrashManager.in.jsm.
Also applied the eslint --fix.
|
||
Updated•2 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/b9168650f5de Rename CrashManager.jsm.in to CrashManager.in.jsm to apply JSM eslint rules. r=gsvelto
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox101:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•