1765964 - [CTW] Don't send scroll position if it's 0

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

BundleFieldsForCache sends a value for scrollPosition even if the frame is not scrollable or it's at position 0 (not scrolled). As a memory optimisation (particularly given that most nodes aren't scrollable), we should assume the nonexistence of the property means the default of 0.

RemoteAccessibleBase is already handling this correctly. We just need to change BundleFieldsForCache to only include if non-0, and include DeleteEntry otherwise (for cache updates).

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1765964: Don't push scrollPosition to the cache if it's 0.

In addition, don't send DeleteEntry for Transform for an initial cache update, since there's nothing to delete.
These fixes don't change the behaviour for users, but optimise both cache storage and IPC trafic.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/206e9f1849c2
Don't push scrollPosition to the cache if it's 0. r=morgan

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/206e9f1849c2