Remove unused PiP pref `media.videocontrols.picture-in-picture.video-toggle.testing`
Categories
(Toolkit :: Picture-in-Picture, task, P3)
Tracking
()
People
(Reporter: kpatenio, Assigned: manisha270417)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
The pref media.videocontrols.picture-in-picture.video-toggle.testing was previously used with our older PiP toggle implementation, changing the toggle animation for .pictureInPictureToggleButton during tests (searchfox). .pictureInPictureToggleButton will be completely removed from the code base once Bug 1765639 is resolved, and I think it will be safe to remove the pref subsequently.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
I made an erroneous assumption that the pref is no longer used. Turns out the pref is still relevant for several toggle-related tests and is used throughout PictureInPictureChild. Removing the pref may only cause more problems with tests, so I will be closing this bug for now.
I have also contacted the bug assignee yesterday regarding this ticket and have informed them that I will be closing it.
Description
•