1766041 - Unify Gecko & Servo's Timing Function Computation

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, enhancement)

Description

[David Shin[:dshin]]

Computation of animation easing-related timing functions are duplicated on C++ and Rust side.

Unifying the two should be possible given the resolution of bug 1496619.

Comment 1

[David Shin[:dshin]]

Attachment: Bug 1766041: Part 1: Move Rust animation to `ComputedTimingFunction`. r=#layout-reviewers

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1766041: Part 2: Update rust's step function basd on C++ `ComputedTimingFunction`. r=#layout-reviewers

Depends on D150565

Comment 3

[David Shin[:dshin]]

Attachment: Bug 1766041: Part 3: Migrate C++ `BeforeFlag` to that of Rust's. r=#layout-reviewers

Depends on D150566

Comment 4

[David Shin[:dshin]]

Attachment: Bug 1766041: Part 4: Create a computed timing function with additional cached data. r=#layout-reviewers

This is for linear(...) easing function where the parsed form requires
additional computation before the output value can be calculated. By
caching the derivation of the output function, we avoid doing so
every step of the animation.

Depends on D150567

Comment 5

[David Shin[:dshin]]

Attachment: Bug 1766041: Part 4: Port bezier edge cases handling from C++ to Rust. r=#layout-reviewers

Depends on D150568

Comment 6

[David Shin[:dshin]]

Attachment: Bug 1766041: Part 6: Remove duplication of timing function related calculations by unifying them into Rust. r=#layout-reviewers

Depends on D150569

Comment 7

[David Shin[:dshin]]

Attachment: Bug 1766041: Part 5: C++ `ComputedTimingFunction` uses Rust's timing function calculation. r=#layout-reviewers

This was made economical by having Rust's computed easing::TimingFunction use
a fully resolved function for linear(...) easing, as per draft resolution from
https://github.com/w3c/csswg-drafts/issues/7415

Depends on D150569

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/315578c436ca
Part 1: Move Rust animation to `ComputedTimingFunction`. r=boris
https://hg.mozilla.org/integration/autoland/rev/ce5a895e7a06
Part 2: Update rust's step function basd on C++ `ComputedTimingFunction`. r=boris
https://hg.mozilla.org/integration/autoland/rev/cc7ffb683e8a
Part 3: Migrate C++ `BeforeFlag` to that of Rust's. r=boris
https://hg.mozilla.org/integration/autoland/rev/5de0ed4fd59b
Part 4: Port bezier edge cases handling from C++ to Rust. r=emilio
https://hg.mozilla.org/integration/autoland/rev/3b0cd4ee7d1e
Part 5: C++ `ComputedTimingFunction` uses Rust's timing function calculation. r=emilio

Comment 9

[Iulian Moraru]

Backed out for gtest failures on APZCBasicTester.

Push with failures

Failure log

Backout link

[task 2022-07-07T23:29:12.967Z] 23:29:12     INFO -  TEST-START | APZCBasicTester.ZoomAndScrollableRectChangeAfterZoomChange
[task 2022-07-07T23:29:12.968Z] 23:29:12  WARNING -  TEST-UNEXPECTED-FAIL | APZCBasicTester.ZoomAndScrollableRectChangeAfterZoomChange | Expected equality of these values:
[task 2022-07-07T23:29:12.968Z] 23:29:12     INFO -    newOffset
[task 2022-07-07T23:29:12.968Z] 23:29:12     INFO -      Which is: 214.63
[task 2022-07-07T23:29:12.968Z] 23:29:12     INFO -    offset
[task 2022-07-07T23:29:12.968Z] 23:29:12     INFO -      Which is: 214.63 @ /builds/worker/checkouts/gecko/gfx/layers/apz/test/gtest/TestBasic.cpp:505
[task 2022-07-07T23:29:12.969Z] 23:29:12  WARNING -  TEST-UNEXPECTED-FAIL | APZCBasicTester.ZoomAndScrollableRectChangeAfterZoomChange | test completed (time: 0ms)
[task 2022-07-07T23:29:12.969Z] 23:29:12     INFO -  TEST-START | APZCBasicTester.ZoomToRectAndCompositionBoundsChange

Comment 10

[David Shin[:dshin]]

Fix incoming

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5153c085ce3
Part 1: Move Rust animation to `ComputedTimingFunction`. r=boris
https://hg.mozilla.org/integration/autoland/rev/d1824a477eec
Part 2: Update rust's step function basd on C++ `ComputedTimingFunction`. r=boris
https://hg.mozilla.org/integration/autoland/rev/fe2e35bcc4d9
Part 3: Migrate C++ `BeforeFlag` to that of Rust's. r=boris
https://hg.mozilla.org/integration/autoland/rev/e42c38a4ae76
Part 4: Port bezier edge cases handling from C++ to Rust. r=emilio
https://hg.mozilla.org/integration/autoland/rev/069ca54ccaa2
Part 5: C++ `ComputedTimingFunction` uses Rust's timing function calculation. r=emilio

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f5153c085ce3
https://hg.mozilla.org/mozilla-central/rev/d1824a477eec
https://hg.mozilla.org/mozilla-central/rev/fe2e35bcc4d9
https://hg.mozilla.org/mozilla-central/rev/e42c38a4ae76
https://hg.mozilla.org/mozilla-central/rev/069ca54ccaa2

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34786 for changes under testing/web-platform/tests

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot