1766044 - [profiler markers] Add CC markers for workers

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement)

Description

[Steve Fink [:sfink] [:s:]]

The "CC" and "CCSlice" markers are mainthread-only, even though workers run the cycle collector.

Comment 1

[Jens Stutte [:jstutte]]

Attachment: WorkerProfilerGCCC.png

There seems to be some CC data also for workers. Is this still relevant?

Comment 2

[Jens Stutte [:jstutte]]

I assume this is still relevant?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

yes

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1766044 - Move CycleCollectorStats from nsJSEnvironment.cpp to its own file

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1766044 - Remove MainThreadCycleCollectorStats and instead make MaybeLogStats and MaybeNotifyStats static functions using sCCStats

Comment 6

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1766044 - Give every cycle collecting thread a stats struct

Comment 7

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1766044 - Move ForgetSkippable marker from mainthread only to a common place

Comment 8

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1766044 - Emit CC start/end markers for all cycle collections, not just mainthread

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/931c77120c31
Move CycleCollectorStats from nsJSEnvironment.cpp to its own file r=mccr8
https://hg.mozilla.org/integration/autoland/rev/bdcaca17283c
Remove MainThreadCycleCollectorStats and instead make MaybeLogStats and MaybeNotifyStats static functions using sCCStats r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a6102546bde2
Give every cycle collecting thread a stats struct r=mccr8
https://hg.mozilla.org/integration/autoland/rev/eac56f66bebe
Move ForgetSkippable marker from mainthread only to a common place r=mccr8
https://hg.mozilla.org/integration/autoland/rev/6caeafb98a86
Emit CC start/end markers for all cycle collections, not just mainthread r=mccr8

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/931c77120c31
https://hg.mozilla.org/mozilla-central/rev/bdcaca17283c
https://hg.mozilla.org/mozilla-central/rev/a6102546bde2
https://hg.mozilla.org/mozilla-central/rev/eac56f66bebe
https://hg.mozilla.org/mozilla-central/rev/6caeafb98a86