1766197 - [wayland] tooltip doesn't appear near the bottom of screen

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[lilydjwg]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

• maximize firefox's window
• open https://en.wikipedia.org/wiki/Main_Page
• hover on the language links at the left bottom

Actual results:

It flickers once but no tooltip is shown. It seems that it tries to show but there is no space and then it disappears soon.

Expected results:

The tooltip should find another place to appear.

It happens on all Wayland sessions of GNOME, KDE and wayfire (wlroots). On Xwayland it doesn't have this issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Yes, I can reproduce that too.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

It's because we create a tooltip under cursor (after move-to-rect), it gets "OnEnterNotifyEvent" and we close the tooltip again.

Comment 4

[Kestrel]

Attachment: Video of picture-in-picture hover tooltip behavior near bottom of screen

This is a lot more noticeable now that hover tooltips have been recently added to the picture-in-picture playback controls (Bug 1772339).

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1766197 [Wayland] Don't set input region to tooltips r?emilio

We don't want to get enter/leave events for tooltip so disable it.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1766197 [Wayland] Update move-to-rect anchor for tooltips according to nsMenuPopupFrame::SetPopupPosition()/X11 r?emilio

Depends on D158565

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55926acc8de0
[Wayland] Don't set input region to tooltips r=emilio
https://hg.mozilla.org/integration/autoland/rev/7882b9b0684c
[Wayland] Update move-to-rect anchor for tooltips according to nsMenuPopupFrame::SetPopupPosition()/X11 r=emilio

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/55926acc8de0
https://hg.mozilla.org/mozilla-central/rev/7882b9b0684c

Comment 10

[Daniel Bodea [:danibodea]]

Using the steps in comment 0, this issue could be reproduced in Release v106.0.1 on Ubuntu 22, after force-opening it with Wayland Window Protocol on gnome Desktop Environment. This issue only occurs when the button or link that also has a tooltip is much too close to the bottom of the screen.

I've confirmed the fix on Beta v107.0b4 and Nightly v108.0a1.