Closed Bug 1766223 Opened 4 years ago Closed 4 years ago

Clear cookies and site data exception for subdomains no longer works in container tabs

Categories

(Toolkit :: Data Sanitization, defect)

Firefox 101
defect

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox99 --- unaffected
firefox100 --- unaffected
firefox101 + fixed

People

(Reporter: ke5trel, Assigned: h.sofie.p)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR:

  1. Enable "Delete cookies and site data when Nightly is closed" and create an exception for https://www.reddit.com.
  2. Visit https://www.reddit.com inside a container tab (eg Personal), note that the address bar indicates permission "Set cookies: Allowed".
  3. Log in to site (or take note of cookies).
  4. Exit browser and restart.

Site is logged out, login cookie is not retained. Manually creating exception https://reddit.com works but this does not appear in the address bar as a permission for the site (separate issue). Creating an exception using the Permission panel in the Page Info window will produce one for https://www.reddit.com which does not work.

This is not limited to www subdomain, the same occurs for https://old.reddit.com.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=26726cd430955db041e5de33d9792bb816c57608&tochange=d60011405047d40685e39b44c97e5da266cc7866

Regressed by Bug 1759579.

Hannah, could you please take a look? Thanks!

Flags: needinfo?(hpeuckmann)

Sure, I have. To speed up the performance the subdomain check was not checking a permission again if it already found a matching principal for this permission in its permissions list. This seems to be the root of this issue, or at least its working fine again when we don't remove those already checked permissions anymore from the list.

Assignee: nobody → hpeuckmann
Flags: needinfo?(hpeuckmann)

Is it possible to create a test for this?

Pushed by hpeuckmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ddecb6341f58 Fix cookie exceptions for subdomains in container tabs.r=pbz
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: