Closed Bug 1766290 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33774 - [renderblocking] Allow manual unblocking of rendering

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33774 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33774
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

[renderblocking] Allow manual unblocking of rendering

This patch makes sure that we can manually unblock rendering on an
element by removing its blocking=render attribute or by simply
removing the element from DOM.

The only new implementation change is that when the blocking
attribute of a \<style> or \<script> element changes, if it changes to
non-render-blocking, then we unblock rendering. All other DOM changes
are already handled by existing code.

This patch also adds new WPT tests for the behavior.

Note: The spec does not require such behavior -- it only requires when
the UA must not render, but there's no requirement of when the UA must
render. So the tests are marked as "optional".

Bug: 1271296
Change-Id: Iead14b73014370ea72e6eeb6714b75cc56de974f

Reviewed-on: https://chromium-review.googlesource.com/3601726
WPT-Export-Revision: d9a903d8863a5115012f91ba1c2e14c25c059436

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 12 subtests

Status Summary

Firefox

OK : 1
PASS : 25
TIMEOUT: 2
NOTRUN : 10

Chrome

OK : 1
PASS : 19
FAIL : 10
TIMEOUT: 2
NOTRUN : 6

Safari

OK : 1
PASS : 20
FAIL : 4
TIMEOUT: 2
NOTRUN : 11

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/dom/render-blocking/remove-attr-unblocks-rendering.optional.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • Loading of parser-inserted modulepreload link should eventually succeed: TIMEOUT (Chrome: PASS, Safari: NOTRUN)
    • Loading of parser-inserted async script should eventually succeed: NOTRUN (Chrome: PASS, Safari: NOTRUN)
    • Loading of parser-inserted defer script should eventually succeed: NOTRUN (Chrome: PASS, Safari: NOTRUN)
    • Loading of parser-inserted module script should eventually succeed: NOTRUN (Chrome: PASS, Safari: NOTRUN)
    • Loading of parser-inserted async module script should eventually succeed: NOTRUN (Chrome: TIMEOUT, Safari: NOTRUN)
    • Loading of script-inserted preload link should eventually succeed: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
    • Loading of script-inserted modulepreload link should eventually succeed: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
    • Loading of script-inserted stylesheet link should eventually succeed: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
    • Loading of script-inserted script should eventually succeed: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
    • Loading of script-inserted module script should eventually succeed: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
    • Loading of script-inserted inline style should eventually succeed: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33b81aef3d69
[wpt PR 33774] - [renderblocking] Allow manual unblocking of rendering, a=testonly
https://hg.mozilla.org/integration/autoland/rev/afb6df10afab
[wpt PR 33774] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.