1766318 - Convert instances of <label is="text-link"> to HTML anchor elements in preferences.xhtml

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Hanna Jones [:hjones]]

There are currently about 80 total instances of <label is="text-link">. Migrating to use HTML anchor elements instead will enable us to eventually remove MozTextLink. To help minimize possible regressions it makes sense to start making these changes one file at a time. preferences.xhtml will be a simple test to see how involved the migration will be, as is="text-link" is only used in three places.

Comment 1

[Hanna Jones [:hjones]]

Attachment: Bug 1766318 - replace is='text-link' with <html:a> in preferences.xhtml r=mstriemer

These changes replicate the exact appearance and behaviour of <label is="text-link">. There are a few possible enhancements not tackled here, as this is the simplest possible migration implementation:

• We could switch to using button elements in this case, based on the styling and the fact that the addonsButton has some additional behaviour on top of navigation. This would necessitate re-working the current style rules a bit.
• Somewhat relatedly, we could change the helpButton and about:policies anchor elements to always switch tabs if the link has already been clicked/opened, rather than always opening in a new tab

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1b188400b53
replace is='text-link' with <html:a> in preferences.xhtml r=preferences-reviewers,Gijs

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e1b188400b53