1766370 - Fix bitfield-enum-conversion warnings in Windows builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Mike Hommey [:glandium]]

js/src/jit/x86-shared/Architecture-x86-shared.h(326,9): error: signed bit-field 'reg_' needs an extra bit to represent the largest positive enumerators of 'XMMRegisterID' [-Werror,-Wbitfield-enum-conversion]
      : reg_(Codes::Encoding(r)), type_(k), isInvalid_(false) {}
        ^
js/src/jit/x86-shared/Architecture-x86-shared.h(310,3): note: consider making the bitfield type unsigned
  Codes::Encoding reg_ : 5;
  ^~~~~~~~~~~~~~~
(...)
js/src/jit/RangeAnalysis.h(378,28): error: signed bit-field 'canHaveFractionalPart_' needs an extra bit to represent the largest positive enumerators of 'FractionalPartFlag' [-Werror,-Wbitfield-enum-conversion]
    canHaveFractionalPart_ = canHaveFractionalPart;
                           ^
js/src/jit/RangeAnalysis.h(227,25): note: consider making the bitfield type unsigned
  MOZ_INIT_OUTSIDE_CTOR FractionalPartFlag canHaveFractionalPart_ : 1;
                        ^~~~~~~~~~~~~~~~~~
(...)
js/src/jit/RangeAnalysis.h(379,24): error: signed bit-field 'canBeNegativeZero_' needs an extra bit to represent the largest positive enumerators of 'NegativeZeroFlag' [-Werror,-Wbitfield-enum-conversion]
    canBeNegativeZero_ = canBeNegativeZero;
                       ^
js/src/jit/RangeAnalysis.h(228,25): note: consider making the bitfield type unsigned
  MOZ_INIT_OUTSIDE_CTOR NegativeZeroFlag canBeNegativeZero_ : 1;
                        ^~~~~~~~~~~~~~~~

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1766370 - Fix bitfield-enum-conversion warnings in Windows builds.

js/src/jit/x86-shared/Architecture-x86-shared.h(326,9): error: signed bit-field 'reg_' needs an extra bit to represent the largest positive enumerators of 'XMMRegisterID' [-Werror,-Wbitfield-enum-conversion]
: reg_(Codes::Encoding(r)), type_(k), isInvalid_(false) {}
^
js/src/jit/x86-shared/Architecture-x86-shared.h(310,3): note: consider making the bitfield type unsigned
Codes::Encoding reg_ : 5;
^~~~~~~~~~~~~~~
(...)
js/src/jit/RangeAnalysis.h(378,28): error: signed bit-field 'canHaveFractionalPart_' needs an extra bit to represent the largest positive enumerators of 'FractionalPartFlag' [-Werror,-Wbitfield-enum-conversion]
canHaveFractionalPart_ = canHaveFractionalPart;
^
js/src/jit/RangeAnalysis.h(227,25): note: consider making the bitfield type unsigned
MOZ_INIT_OUTSIDE_CTOR FractionalPartFlag canHaveFractionalPart_ : 1;
^~~~~~~~~~~~~~~~~~
(...)
js/src/jit/RangeAnalysis.h(379,24): error: signed bit-field 'canBeNegativeZero_' needs an extra bit to represent the largest positive enumerators of 'NegativeZeroFlag' [-Werror,-Wbitfield-enum-conversion]
canBeNegativeZero_ = canBeNegativeZero;
^
js/src/jit/RangeAnalysis.h(228,25): note: consider making the bitfield type unsigned
MOZ_INIT_OUTSIDE_CTOR NegativeZeroFlag canBeNegativeZero_ : 1;
^~~~~~~~~~~~~~~~

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3e2641c90ce
Fix bitfield-enum-conversion warnings in Windows builds. r=jandem

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing spidermonkey bustage

• backout: https://hg.mozilla.org/integration/autoland/rev/d7ad2eff79c5401a961858021ffdbf727e9b79ff
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=HxU431uNTOeux9brtzxnuw.0&revision=b3e2641c90ce9227141dedb4769cf24e24933ec3
• failure log: https://treeherder.mozilla.org/logviewer?job_id=375782253&repo=autoland&lineNumber=1601

[task 2022-04-26T07:07:04.563Z] In file included from /builds/worker/checkouts/gecko/js/src/jit/Registers.h:14:0,
[task 2022-04-26T07:07:04.563Z]                  from /builds/worker/checkouts/gecko/js/src/wasm/WasmFrame.h:266,
[task 2022-04-26T07:07:04.563Z]                  from /builds/worker/checkouts/gecko/js/src/wasm/WasmDebugFrame.h:30,
[task 2022-04-26T07:07:04.563Z]                  from /builds/worker/checkouts/gecko/js/src/vm/Stack.h:30,
[task 2022-04-26T07:07:04.563Z]                  from /builds/worker/checkouts/gecko/js/src/vm/Activation.h:25,
[task 2022-04-26T07:07:04.563Z]                  from /builds/worker/checkouts/gecko/js/src/vm/JSContext.h:32,
[task 2022-04-26T07:07:04.563Z]                  from /builds/worker/checkouts/gecko/js/src/util/AllocPolicy.cpp:9,
[task 2022-04-26T07:07:04.563Z]                  from Unified_cpp_js_src_util0.cpp:2:
[task 2022-04-26T07:07:04.563Z] /builds/worker/checkouts/gecko/js/src/jit/x86-shared/Architecture-x86-shared.h:310:26: error: 'js::jit::FloatRegister::reg_' is too small to hold all values of 'using Encoding = enum js::jit::X86Encoding::XMMRegisterID {aka enum js::jit::X86Encoding::XMMRegisterID}' [-Werror]
[task 2022-04-26T07:07:04.563Z]    Codes::Encoding reg_ : 5;
[task 2022-04-26T07:07:04.563Z]                           ^
[task 2022-04-26T07:07:04.563Z] cc1plus: all warnings being treated as errors
[task 2022-04-26T07:07:04.563Z] gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:659: Unified_cpp_js_src_util0.o] Error 1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/206cd458a5eb
Fix bitfield-enum-conversion warnings in Windows builds. r=jandem

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/206cd458a5eb