1766385 - L10nRegistry::getSource() crashes if a source with that name doesnt exist

Status: RESOLVED WORKSFORME

(Core :: Internationalization: Localization, defect)

Description

[Beth Rennie [:beth] (she/her)]

Steps to reproduce

In the browser console:

L10nRegistry.getInstance().getSource("bogus")

Expected Results

The browser should not crash

Actual results

The browser crashes

I stumbled upon this because I was debugging some RemoteL10n things and the "cfr" source had not been loaded when I called getSource() for it.

---

Crash report: https://crash-stats.mozilla.org/report/index/ef268bf3-75fc-4098-b88f-b8fb40220426

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll nsstring::impl$14::adapt xpcom/rust/nsstring/src/lib.rs:1192
1 xul.dll nsstring::nsACString::assign<alloc::string::String> xpcom/rust/nsstring/src/lib.rs:498
2 xul.dll mozilla::dom::L10nFileSource_Binding::get_name dom/bindings/L10nRegistryBinding.cpp:1633
3 xul.dll mozilla::dom::binding_detail::GenericGetter<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3152
4 xul.dll js::Call js/src/vm/Interpreter.cpp:605
5 xul.dll static js::DebuggerObject::call js/src/debugger/Object.cpp:2374
6 xul.dll js::DebuggerObject::CallData::callMethod js/src/debugger/Object.cpp:950
7 xul.dll static js::DebuggerObject::CallData::ToNative<&js::DebuggerObject::CallData::callMethod> js/src/debugger/Object.cpp:241
8 xul.dll Interpret js/src/vm/Interpreter.cpp:3314
9 xul.dll js::Call js/src/vm/Interpreter.cpp:605

Comment 1

[Beth Rennie [:beth] (she/her)]

Clearing Severity: S2 because this is /not/ an S2 and I only found it via the browser console.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:eemeli, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.