1766395 - Calendar input form is opened twice

Status: VERIFIED FIXED

(GeckoView :: IME, defect)

Description

[Mihai Adrian Carare [:mcarare]]

101.0.20220425094217 introduced a regression that manifests in opening a modal dialog twice ( a calendar input form in the failing tests for PR that adds the upgrade to this version).

Comment 1

[Julien Cristau [:jcristau]]

Could be caused by bug 1764157?

Comment 2

[Mihai Adrian Carare [:mcarare]]

I think it is likely so.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1764157

Comment 4

[Ryan VanderMeulen [:RyanVM]]

To be clear, this is currently blocking Focus AC bumps. Not sure why Fenix tests are managing to still pass, but Focus is permafailing.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1766395 - Remove dom.forms.datetime-local prefs. r=smaug,edgar

We shipped this a while ago.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1766395 - Don't use click event to show date/time/datetime-local input. r=Agi

MozShowDateTimePicker should be enough for this. We keep using click for
week / month because those don't implement a widget cross-platform.

Depends on D144800

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/235c964e238b
Remove dom.forms.datetime-local prefs. r=edgar

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c704651eb4b7
Don't use click event to show date/time/datetime-local input. r=agi

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/235c964e238b
https://hg.mozilla.org/mozilla-central/rev/c704651eb4b7

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Verified fixed in today's AC bump. Thanks!

Comment 12

[Chris Peterson [:cpeterson]]

Moving some input bugs to the new GeckoView::IME component.