1766436 - [Experiment] The "ECO" spotlight would be displayed even if Firefox is already pinned to the taskbar/dock

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: ss of the issue.png

[Notes]:

• Unfortunately we cannot validate this scenario since we are blocked by bug 1766430, however, we observed that the doesAppNeedPin attribute is missing from the full targeting experssion.

[Affected versions]:

• Firefox Beta 100.0 - Build ID: 20220425210429

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6.2

[Prerequisites]:

• Have a Firefox en-* locale build installed.
• Have Firefox pinned to the taskbar/dock.
• Have the "user.js" file saved to your PC.

[Steps to reproduce]:

1. Open the browser using the profile from the prerequisites.
2. Navigate to the profile folder and paste the "user.js" file from the prerequisites.
3. Restart the browser and observe the behavior.

[Expected result]:

• The "ECO" spotlight is NOT displayed.

[Actual result]:

• The ECO spotlight is displayed even if Firefox is pinned to the taskbar/dock.

[Notes]:

• Attached a screenshot with the targeting expression.

Comment 1

[Ed Lee :Mardak]

We need a new advanced targeting like the one for casual unpinned https://github.com/mozilla/experimenter/blob/12ab7b459560c9978cdd203e4ca7054813637bed/app/experimenter/experiments/constants/nimbus.py#L379-L383

Comment 2

[Ed Lee :Mardak]

This should be fixed on preview https://firefox.settings.services.mozilla.com/v1/buckets/main/collections/nimbus-preview/records/covered-regular-eco2204 currently showing (userMonthlyActivity|length >= 21 && (currentDate|date - profileAgeCreated|date) / 86400000 >= 28 && doesAppNeedPin || experiment.slug in activeExperiments) && (browserSettings.update.channel == \"release\") && ('app.shield.optoutstudies.enabled'|preferenceValue) && (version|versionCompare('100.!') >= 0) && (locale in ['en-CA', 'en-GB', 'en-US'])

Comment 3

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Release (100.0 Build ID - 20220428192727) installed on Windows 10 x64 and macOS 10.15.7. Now I can confirm that the profile is not enrolled in the covered-regular-eco2204 experiment if the browser is already pinned to the taskbar/dock.