1766441 - Remove code that sets study prefs on TCP rollout phase 1 opt-in /out

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Description

[Paul Zühlcke [:pbz]]

Remove the code here https://searchfox.org/mozilla-central/rev/0249c123e74640ed91edeabba00649ef4d929372/browser/components/BrowserGlue.jsm#1772-1798 along with the test parts.

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1766441 - Remove study prefs set on TCP rollout opt-in/out. r=timhuang!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ae5ccd908de
Remove study prefs set on TCP rollout opt-in/out. r=timhuang

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4ae5ccd908de

Comment 4

[Paul Zühlcke [:pbz]]

[Tracking Requested - why for this release]:
We'd like to have this as a ride along for the dot release. It's currently blocking the first phase of the TCP rollout. I'll create an uplift request soon.

Comment 5

[:Gijs (he/him)]

Discussed this with Paul. This seems reasonable to uplift to release.

Comment 6

[Paul Zühlcke [:pbz]]

Comment on attachment 9273864 [details]
Bug 1766441 - Remove study prefs set on TCP rollout opt-in/out. r=timhuang!

Beta/Release Uplift Approval Request

• User impact if declined: This blocks the Total Cookie Protection rollout scheduled for (during) Firefox 100. This patch removes code that sets search prefs for enrolled clients. These search param prefs can interfere with other Nimbus or Normandy search experiments, leading to inaccurate experiment data or failure to enroll users.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Observe the following pref state initially (you can check via about:config)
  network.cookie.cookieBehavior = 4
browser.search.param.google_channel_us not set
  browser.search.param.google_channel_row not set
  browser.search.param.bing_ptag not set

(a) Via about:config add a boolean pref privacy.restrict3rdpartystorage.rollout.enabledByDefault and set it to true

Observe the following pref state (you can check via about:config)
network.cookie.cookieBehavior = 5
browser.search.param.google_channel_us not set
browser.search.param.google_channel_row not set
browser.search.param.bing_ptag not set

Repeat the test with a clean profile, but in step (a) set the pref to false.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Has automated test coverage. Small production code change. The production code affected is only called as part of a gradual rollout, further reducing risk.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this task using the steps received in comment 6 and I cand confirm the following:

1. The initial pref values are:

• network.cookie.cookieBehavior set to 4
• browser.search.param.google_channel_us not set
• browser.search.param.google_channel_row not set
• browser.search.param.bing_ptag not set

2. With the privacy.restrict3rdpartystorage.rollout.enabledByDefault set to true:

• network.cookie.cookieBehavior set to 5
• browser.search.param.google_channel_us not set
• browser.search.param.google_channel_row not set
• browser.search.param.bing_ptag not set

3. With the privacy.restrict3rdpartystorage.rollout.enabledByDefault set to false:

• network.cookie.cookieBehavior set to 4
• browser.search.param.google_channel_us not set
• browser.search.param.google_channel_row not set
• browser.search.param.bing_ptag not set

Verified using the latest Firefox Beta (101.0b3 Build ID - 20220505190214) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64.

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9273864 [details]
Bug 1766441 - Remove study prefs set on TCP rollout opt-in/out. r=timhuang!

Approved for 100.0.1

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/d67af466212e

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

This task was part of the work done on QA-1487 for which we sent a sign-off via email. Considering this I will mark it as Verified.