Closed Bug 1766465 Opened 2 years ago Closed 2 years ago

Implement new "Super Nova" icons in the tabmail tabs

Categories

(Thunderbird :: Theme, task)

Tracking

(Not tracked)

RESOLVED FIXED
102 Branch

People

(Reporter: aleca, Assigned: micah)

Details

Attachments

(2 files)

The new icons (project name Super Nova), landed on the Spaces Toolbar.
We should replace the old icons we currently use in the Titlebar Tabs for those tabs matching the new icons.

  • Calendar
  • Address Book
  • Tasks
  • Chat
  • Settings

Direction
We could use the occasion to create an icons.css file which will hold the variable definitions of all the icons used across the application.
We can then import that file wherever it's needed and use the the variable name to apply the icon.

Some icons are hardcoded via JS or directly in the XHTML file.
Let's investigate if it makes sense to remove that and trying to stick with CSS.

Attachment #9274356 - Attachment description: WIP: Bug 1766465 - Implement new tab icons → Bug 1766465 - Implement new tab icons r=aleca
Status: NEW → ASSIGNED
Target Milestone: --- → 102 Branch
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Temporarily reopening this for a quick fix that needs to land.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/fc6972c76d41
Override settings icon in the add-ons tab. r=Paenglab

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED

I noticed that the "about:config" icon is filled with black. I think it is to do with the missing "supernova" class. This comment describes it as temporary https://searchfox.org/comm-central/rev/58c97c6367fe26806f1dd50f24d24900fe9df995/mail/base/content/tabmail.js#892 so I imagine it'll get fixed in the future. However, its not clear whether this will be before or after 102? If it would be after, can we add "about:config" to the list now?

Flags: needinfo?(alessandro)

All icons will be replaced before the end of the month, so that issue (and the class) is just temporary.
Thanks for the heads up :D

Flags: needinfo?(alessandro)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: