1766510 - Perma [tier 2] /builds/worker/fetches/clang/bin/../i686-w64-mingw32/include/comdef.h:131:5: error: call to deleted function 'FormatMessage'

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=375859568&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/asAeQTZJRTqqs06PkO7HVA/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-04-26T19:47:57.430Z] 19:47:57  WARNING -  /builds/worker/checkouts/gecko/browser/components/shell/nsWindowsShellService.cpp:49:10: warning: redeclaration of 'PropVariantToString' should not add 'dllimport' attribute [-Wdll-attribute-on-redeclaration]
[task 2022-04-26T19:47:57.430Z] 19:47:57     INFO -  PSSTDAPI PropVariantToString(REFPROPVARIANT propvar, PWSTR psz, UINT cch);
[task 2022-04-26T19:47:57.431Z] 19:47:57     INFO -           ^
[task 2022-04-26T19:47:57.431Z] 19:47:57     INFO -  /builds/worker/fetches/clang/bin/../i686-w64-mingw32/include/propvarutil.h:93:16: note: previous declaration is here
[task 2022-04-26T19:47:57.431Z] 19:47:57     INFO -  HRESULT WINAPI PropVariantToString(REFPROPVARIANT propvarIn, PWSTR ret, UINT cch);
[task 2022-04-26T19:47:57.431Z] 19:47:57     INFO -                 ^
[task 2022-04-26T19:47:57.432Z] 19:47:57     INFO -  In file included from /builds/worker/checkouts/gecko/browser/components/shell/nsWindowsShellService.cpp:55:
[task 2022-04-26T19:47:57.432Z] 19:47:57     INFO -  In file included from /builds/worker/fetches/clang/bin/../i686-w64-mingw32/include/comutil.h:1217:
[task 2022-04-26T19:47:57.432Z] 19:47:57    ERROR -  /builds/worker/fetches/clang/bin/../i686-w64-mingw32/include/comdef.h:131:5: error: call to deleted function 'FormatMessage'
[task 2022-04-26T19:47:57.432Z] 19:47:57     INFO -      FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER|FORMAT_MESSAGE_FROM_SYSTEM,NULL,m_hresult,MAKELANGID(LANG_NEUTRAL,SUBLANG_DEFAULT),(LPTSTR)&m_pszMsg,0,NULL);
[task 2022-04-26T19:47:57.433Z] 19:47:57     INFO -      ^~~~~~~~~~~~~
[task 2022-04-26T19:47:57.433Z] 19:47:57     INFO -  /builds/worker/workspace/obj-build/dist/stl_wrappers/windows.h:1047:1: note: candidate function has been explicitly deleted
[task 2022-04-26T19:47:57.433Z] 19:47:57     INFO -  FormatMessage(DWORD a0, LPCVOID a1, DWORD a2, DWORD a3, LPTSTR a4, DWORD a5, va_list* a6)
[task 2022-04-26T19:47:57.433Z] 19:47:57     INFO -  ^
[task 2022-04-26T19:47:57.434Z] 19:47:57  WARNING -  /builds/worker/checkouts/gecko/browser/components/shell/nsWindowsShellService.cpp:806:39: warning: format specifies type 'wchar_t *' but the argument has type 'typename raw_type<char16_t, int>::type' (aka 'char16ptr_t') [-Wformat]
[task 2022-04-26T19:47:57.434Z] 19:47:57     INFO -      arguments.AppendPrintf("\"%S\" ", arg.get());
[task 2022-04-26T19:47:57.434Z] 19:47:57     INFO -                                ~~      ^~~~~~~~~
[task 2022-04-26T19:47:57.435Z] 19:47:57  WARNING -  /builds/worker/checkouts/gecko/browser/components/shell/nsWindowsShellService.cpp:1273:21: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned int') [-Wsign-compare]
[task 2022-04-26T19:47:57.435Z] 19:47:57     INFO -    for (int i = 0; i < ArrayLength(shortcutCSIDLs); ++i) {
[task 2022-04-26T19:47:57.435Z] 19:47:57     INFO -                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-04-26T19:47:57.436Z] 19:47:57  WARNING -  /builds/worker/checkouts/gecko/browser/components/shell/nsWindowsShellService.cpp:1540:21: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned int') [-Wsign-compare]
[task 2022-04-26T19:47:57.436Z] 19:47:57     INFO -    for (int i = 0; i < ArrayLength(folders); ++i) {
[task 2022-04-26T19:47:57.436Z] 19:47:57     INFO -                    ~ ^ ~~~~~~~~~~~~~~~~~~~~
[task 2022-04-26T19:47:57.436Z] 19:47:57     INFO -  4 warnings and 1 error generated.
[task 2022-04-26T19:47:57.437Z] 19:47:57    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:658: nsWindowsShellService.o] Error 1
[task 2022-04-26T19:47:57.437Z] 19:47:57     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/browser/components/shell'
[task 2022-04-26T19:47:57.437Z] 19:47:57    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: browser/components/shell/target-objects] Error 2
[task 2022-04-26T19:47:57.437Z] 19:47:57     INFO -  gmake[3]: *** Waiting for unfinished jobs....
[task 2022-04-26T19:47:57.438Z] 19:47:57     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'
[task 2022-04-26T19:47:57.438Z] 19:47:57     INFO -  config/external/wasm2c_sandbox_compiler/host_error-formatter.o
[task 2022-04-26T19:47:57.438Z] 19:47:57     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/config/external/wasm2c_sandbox_compiler'

Comment 1

[Norisz Fay [:noriszfay]]

Hello, this bustage appearad as tier 2 so far starting with this push (Bug 1763573). Could you take a look please?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1763573

Comment 3

[[e-mail] (:bhearsum)]

This is clearly the result my patch, but I'm unclear on the fix. This won't have a patch until at least tomorrow.

Comment 4

[mac198442]

(In reply to [e-mail] (:bhearsum) from comment #3)

This is clearly the result my patch, but I'm unclear on the fix. This won't have a patch until at least tomorrow.

How about re-instating the first patch but put the return inside a #ifdef MINGW32 ?

Comment 5

[[e-mail] (:bhearsum)]

(In reply to mac198442 from comment #4)

(In reply to [e-mail] (:bhearsum) from comment #3)

This is clearly the result my patch, but I'm unclear on the fix. This won't have a patch until at least tomorrow.

How about re-instating the first patch but put the return inside a #ifdef MINGW32 ?

I was hoping to avoid that, so I don't have to disable the code that depends on comutil.h -- but I may end up going this route in the end.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: Bug 1766510: fix windows 7 taskbar pinning code in mingw builds r?rkraesig

It's not my preference to disable this, but no matter how I fiddled with the imports I wasn't able to get this to compile with mingw -- it always complained that FormatMessage had been deleted. (This is curious, because we have other code that definitely uses comutil.h without issue on Windows -- but I'm not sure it's probably not worth debugging this for a build we don't ship, on platforms that are so old.)

Comment 7

[mac198442]

(In reply to [e-mail] (:bhearsum) from comment #6)

Created attachment 9274055 [details]
Bug 1766510: disable Windows 7/8 taskbar pinning on mingw builds r?rkraesig

It's not my preference to disable this, but no matter how I fiddled with the imports I wasn't able to get this to compile with mingw -- it always complained that FormatMessage had been deleted. (This is curious, because we have other code that definitely uses comutil.h without issue on Windows -- but I'm not sure it's probably not worth debugging this for a build we don't ship, on platforms that are so old.)

how odd I was bout to post this as a patch. Great minds think alike. And sometimes us idiots do also!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42f3aa6ba86f
fix windows 7 taskbar pinning code in mingw builds r=rkraesig

Comment 9

[Intermittent Failures Robot]

57 failures in 340 pushes (0.168 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 45
• mozilla-central: 12

Platform and build breakdown:

• windows-mingw32: 57
  • all: 57

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1766510&startday=2022-04-27&endday=2022-04-27&tree=all

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/42f3aa6ba86f

Comment 11

[Intermittent Failures Robot]

69 failures in 3289 pushes (0.021 failures/push) were associated with this bug in the last 7 days.

This is the #8 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 57
• mozilla-central: 12

Platform and build breakdown:

• windows-mingw32: 69
  • all: 69

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1766510&startday=2022-04-25&endday=2022-05-01&tree=all