1766524 - Consistently style all menupopups across platforms to respect TB themeing and Density variation

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Alessandro Castellani [:aleca]]

We have various menupopups used around the application, some have the cui-widget-panel class, some don't.

Those that don't are styled by the OS, those that have that class come with a consistent style across platforms, as well as properly respecting light/dark variation and density variation.

I think we should make a decision and aim for visual consistency and enforce the same style to all our menupopup elements.
https://searchfox.org/comm-central/rev/5e4def2a2afe978ffeeed96e2f3c0d4a8a80d816/mail/base/content/mainMailToolbar.inc.xhtml#228-229

Comment 1

[Richard Marti (:Paenglab)]

On Mac the popups opened through openPopupAtScreen() have still the system appearance. Look at AB's bookContext or cardContext.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug 1766524 - Use contextMenu.css to style all menus in main window. r=aleca

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug 1766524 - Remove the cui-widget-panel class from menupopups in main window. r=aleca

Depends on D145092

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f530dd9a9552
Use contextMenu.css to style all menus in main window. r=aleca
https://hg.mozilla.org/comm-central/rev/4ead5714d4be
Remove the cui-widget-panel class from menupopups in main window. r=aleca

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5353e5b783fb
follow-up, fix linting. rs=eslint DONTBUILD

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Bug 1766524 - Mac: Hide the second checkmark on main window menu. r=aleca

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/912202005e04
Mac: Hide the second checkmark on main window menu. r=aleca

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug 1766524 - Remove the cui-widget-panel class from menupopups in composer window. r=aleca

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/11708dc825f8
Remove the cui-widget-panel class from menupopups in composer window. r=aleca

Comment 10

[Rob Lemley [:rjl]]

(In reply to Pulsebot from comment #9)

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/11708dc825f8
Remove the cui-widget-panel class from menupopups in composer window. r=aleca

Uplift to comm-beta? It fixes missing check-marks in the OpenPGP compose toolbar button dropdown. (Earlier patches are already on comm-beta.)

Comment 11

[Richard Marti (:Paenglab)]

Comment on attachment 9274676 [details]
Bug 1766524 - Remove the cui-widget-panel class from menupopups in composer window. r=aleca

[Approval Request Comment]
User impact if declined: Inconsistent appearance and PGP popup missing checkmarks
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be not too risky

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9274676 [details]
Bug 1766524 - Remove the cui-widget-panel class from menupopups in composer window. r=aleca

[Triage Comment]
Approved for beta

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 101.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/76df63b45b99

Comment 14

[Magnus Melin [:mkmelin]]

Is this bug finished?

Comment 15

[Richard Marti (:Paenglab)]

No, I need to add more dialogs like Events.

Comment 16

[Richard Marti (:Paenglab)]

Attachment: Bug 1766524 - Convert more dialogs to contextMenu.css. r=aleca

Comment 17

[Richard Marti (:Paenglab)]

Attachment: Bug 1766524 - Cleanup after using contextMenu.css. r=aleca

Depends on D146326

Comment 18

[Richard Marti (:Paenglab)]

If we find other dialogs we can do this in separate bugs.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fbaef6eb7701
Convert more dialogs to contextMenu.css. r=aleca
https://hg.mozilla.org/comm-central/rev/bad91e465d3d
Cleanup after using contextMenu.css. r=aleca