1766555 - [wpt-sync] Sync PR 33806 - Remove DCHECK() expecting all or none of the properties for an animation to be composited.

Status: RESOLVED FIXED

(Core :: DOM: Animation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33806 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33806
Details from upstream follow.

L. David Baron <[e-mail]> wrote:

Remove DCHECK() expecting all or none of the properties for an animation to be composited.

Being stricter about compositing only the relevant property tree nodes
for relevant animations (https://crrev.com/c/3307117) has made the
DCHECK()s in CompositorPropertyAnimationsHaveNoEffect more sensitive.
In particular, those DCHECK()s, which ensure that either no properties
of an animation or all properties of an animation are composited, appear
to run for animations that are not current. This is a case where other
animations might have caused some (but not all) of the properties to be
composited, yet this animation (in UpdateAnimationFlagsForAnimation in
css_animations.cc) will not set the flags for this animation that cause
the properties it animates to be composited.

I believe, given that, that these DCHECK()s are not valid. It appears
to me that the code is otherwise correct despite the DCHECK()s, since I
think the behavior that it was following is correct for the case where
the two things being tested (all present, any present) turn out not to
be equivalent.

Fixed: 1319304
Change-Id: If3db29b98ce319c57e27acbe2f47d7319ec8230b
Reviewed-on: https://chromium-review.googlesource.com/3609191
WPT-Export-Revision: 075e67c7221a47c24a2898a4d5d6ac6803f75b14

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=08fb956a68a6e371926eb68189b1d3dab37ac086

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5258e316ed1a
[wpt PR 33806] - Avoid calling CompositorPropertyAnimationsHaveNoEffect when effect->IsCurrent() is false., a=testonly

Comment 4

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/5258e316ed1a