1766560 - [CTW] First line start of a leaf is ignored when fetching the next line start

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

STR:

1. Open this test case:
   data:text/html,<div contenteditable style="width: 2ch; word-break: break-word;"><span>a</span>bc
2. Query the HyperText line offsets at offset 0.
   • Expected: (0, 2, "ab")
   • Actual: (0, 3, "abc")

This is due to a silly logic error in FindLineStartSameRemoteAcc.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1766560: Don't ignore the first line start of a RemoteAccessible when retrieving the next line.

The code previously returned failure for array index 0, but it did this for both movement directions.
It should only do this for eDirPrevious, since we decrement index in that case.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a901a6c26367
Don't ignore the first line start of a RemoteAccessible when retrieving the next line. r=morgan

Comment 3

[Atila Butkovits]

Backed out for causing failures at browser_caching_text.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8372bb6df9bf8b274f3d4fc568716a48802aeec2

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a901a6c263672b4a625a7d5948c8a70d330ca7e6

Failure log: https://treeherder.mozilla.org/logviewer?job_id=376050692&repo=autoland&lineNumber=2640

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc5eb6e5dc92
Don't ignore the first line start of a RemoteAccessible when retrieving the next line. r=morgan

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bc5eb6e5dc92