Closed
Bug 1766651
Opened 2 years ago
Closed 2 years ago
Remove nsIPrintSettings.isCancelled and nsIPrintSettings.saveOnCancel
Categories
(Core :: Printing: Setup, task, P3)
Core
Printing: Setup
Tracking
()
RESOLVED
FIXED
101 Branch
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•2 years ago
|
Summary: Remove nsIPrintSettings.isCancelled → Remove nsIPrintSettings.isCancelled and nsIPrintSettings.saveOnCancel
|
|
Assignee | |
Comment 1•2 years ago
|
||
nsIPrintSettings.isCancelled was only being set to true by the Windows widget
code ShowNativePrintDialog nowadays. That seems pointless since that widget
code is only invoked under the _showPrintDialog call in print.js, and in the
case that the widget code throws, the print is never invoked and the
nsIPrintSettings object isn't used.
nsIPrintSettings.saveOnCancel was set in some places but never read.
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/7f1e8ecd947e Remove nsIPrintSettings.isCancelled and nsIPrintSettings.saveOnCancel. r=bobowen
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox101:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•