Closed Bug 1766714 Opened 2 years ago Closed 2 years ago

MyFirefox FxA setup - Enable the tab sync pref and complete setup flow

Categories

(Firefox :: Sync, enhancement, P3)

Desktop
All
enhancement
Points:
3

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox101 --- wontfix
firefox102 --- fixed

People

(Reporter: sfoster, Assigned: sfoster)

References

(Regressed 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-myfirefox])

Attachments

(1 file)

The third step in the setup flow is to show a button to enable tab syncing if its not already enabled. This step gets skipped otherwise.

Finally, the user is given an opportunity to confirm with a in-region prompt before we show the synced tabs listing. As initial sync takes an indeterminate amount of time, this is also where we can show a waiting message. "Setup complete" and the "Get my other tabs" button appear when sync has taken place and the tab data is ready

Points: 8 → 3

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Networking' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → DOM: Networking
Product: Firefox → Core
Component: DOM: Networking → Sync
Product: Core → Firefox
Whiteboard: [fidefe-2022-mr1-myfirefox]
  • Observe the 'services.sync.engine.tabs' pref and skip the tab sync step when it is enabled
  • Hook up the primary button on that step to enable the pref
  • Add tests for both paths through this setup
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75ea4a45632b
Advance fxview sync setup to next state when services.sync.engine.tabs is enabled. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Flags: in-testsuite+
Regressions: 1770865
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: