Closed Bug 1766732 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 33825 - Check for existing symlink in unzip helper

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox102 fixed)

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33825 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33825
Details from upstream follow.

Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com> wrote:

Check for existing symlink in unzip helper

I was trying to update my Chromium binary locally and ran across this new error:

FileExistsError: [Errno 17] File exists: b'Versions/Current/Resources' -> '/Users/danielrsmith/projects/wpt/_venv3/browsers/nightly/chrome-mac/Chromium.app/Contents/Frameworks/Chromium Framework.framework/Resources'

It seems to be caused by trying to establish a symlink that already exists. Unlinking before trying to establish a new symlink resolves the issue.

PR 33825 applied with additional changes from upstream: 8913e7d394103ece591af3ec65a9b9a4126ddaea
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/79b6c99f2acf [wpt PR 33825] - Check for existing symlink in unzip helper, a=testonly

https://hg.mozilla.org/mozilla-central/rev/79b6c99f2acf

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.