[wpt-sync] Sync PR 33831 - Chromium - Check file download availability correctly
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox102 fixed)
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream error])
Sync web-platform-tests PR 33831 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/33831
Details from upstream follow.
Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com> wrote:
Chromium - Check file download availability correctly
I spotted a small error in the implementation of checking the status of a Chromium download link availability:
https://github.com/web-platform-tests/wpt/blob/905502574b6c12bf568dd13cc96c223f5cf3b5cf/tools/wpt/browser.py#L550-L554This url needs to also provide the file name that is attempting download to ensure availability. This request check would always fail.
This check is very seldom used, as it is only done if all of these conditions are met:
- The user is trying to download Chromium ChromeDriver.
- Chromium's browser version is detected.
- The Chromium browser has NOT been downloaded in this execution (which uses the same url and revision)
- We have successfully detected a revision number based on the browser version, AND that revision number is available for download from Chromium snapshots.
The only feasible way this scenario would happen is if Chromium was downloaded on the user's machine, they did not download the matching ChromeDriver (for some reason), and then time passed and a Chromium run was attempted. My guess is that this has not yet happened. Regardless, this will fix this case. 🙂
|
Assignee | |
Updated•2 years ago
|
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ab9196f8f1e [wpt PR 33831] - Chromium - Check file download availability correctly, a=testonly
Description
•