Closed Bug 1766851 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33844 - Require LayoutBox to defer style recalc to layout-time

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33844 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33844
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

Require LayoutBox to defer style recalc to layout-time

A LayoutBox is required for NGBlockNode, so eagerly recalc skipped
subtrees during layout-tree building if we did not get a LayoutBox.

Additionally, check NGBlockNode::CanUseNewLayout, as this is checked
by NGBlockNode::Layout to early-out at the start of the function.

Also, rename MaySkipNGBlockNodeLayout to something which does not
involve the word "skip". It's nice to reserve "skip" in this context
to refer to the style recalc being skipped for a certain set of
descendants.

Fixed: 1313444
Change-Id: Idc875a3635eedb61401e91e9fab90b713f693b21
Reviewed-on: https://chromium-review.googlesource.com/3613303
WPT-Export-Revision: 48b87af62a0a7e70f96f922a878a9898a12dced2

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e96691b2786
[wpt PR 33844] - Require LayoutBox to defer style recalc to layout-time, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7e96691b2786

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.