Closed Bug 1767050 Opened 2 years ago Closed 2 years ago

Tags not shown in tag menu of the standalone window - Uncaught TypeError: can't access property "label"

Categories

(Thunderbird :: Mail Window Front End, defect)

Thunderbird 98
defect

Tracking

(thunderbird_esr91 unaffected, thunderbird100 affected, thunderbird102+ fixed)

RESOLVED FIXED
102 Branch
Tracking Status
thunderbird_esr91 --- unaffected
thunderbird100 --- affected
thunderbird102 + fixed

People

(Reporter: Paenglab, Assigned: mkmelin)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

In standalone window are no tags listed in the tags menu. And in main menu the tags menuitem is disabled.

In console I get:
Uncaught TypeError: can't access property "label", message is undefined
InitMessageTags chrome://messenger/content/mailWindowOverlay.js:1513
onpopupshowing chrome://messenger/content/messageWindow.xhtml:1
mailWindowOverlay.js:1513:18

This has probably been broken for a while now but no one noticed it.
Sean, would you be able to take a look at this when you have time.
Having this fixed before 102 would be nice, so in the next month or 2.

Displays fine for me using current beta on Mac.
Is this failing only on trunk?

Summary: Tags not shown in tag menu of the standalone window → Tags not shown in tag menu of the standalone window - Uncaught TypeError: can't access property "label"

No, looks like from bug 1752037

Regressed by: 1752037

Here and in several other places, I've collected some variables depending on the current tab. I haven't accounted for this file being used on the standalone window where there are no tabs. That's the cause.

Severity: -- → S3
Version: unspecified → Thunderbird 98
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED

This is also causing e.g. the Message | Copy To menu to be disabled for an .eml opened from file

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8524c8e1591c
Fix menu initialization for a bunch of menus when opened standalone .eml file. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: